Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a check for Visual C++ Redistributable during install time. #7609

Closed
wants to merge 2 commits into from
Closed

Added a check for Visual C++ Redistributable during install time. #7609

wants to merge 2 commits into from

Conversation

Mailaender
Copy link
Member

@Mailaender Mailaender mentioned this pull request Mar 7, 2015
Merged
@Mailaender Mailaender added this to the Next release milestone Mar 7, 2015
@pchote
Copy link
Member

pchote commented Mar 7, 2015

I really don't like the idea of forcing people to install additional prerequisites. We have gone for years without this being a problem.

@Mailaender
Copy link
Member Author

Okay, reverting back to Microsoft Visual C++ 6.0 compiler in #7611 for FreeType2 which we used before.

@Mailaender Mailaender removed this from the Next release milestone Mar 7, 2015
@Mailaender
Copy link
Member Author

Superseded by #7579.

@Mailaender Mailaender closed this Mar 7, 2015
@Mailaender Mailaender deleted the nsis-msvc110 branch March 7, 2015 16:42
@Mailaender Mailaender restored the nsis-msvc110 branch June 16, 2015 15:47
@Mailaender Mailaender reopened this Jun 16, 2015
@Mailaender
Copy link
Member Author

I am bringing this back, but ask for the 2010 (instead of 2012) one which is enough now. Fixes #8493.

@Mailaender Mailaender mentioned this pull request Jun 16, 2015
Closed
penev92
penev92 reviewed Jun 19, 2015
View reviewed changes
packaging/windows/OpenRA.nsi
@@ -170,6 +170,24 @@ Section "-DotNet" DotNet
done:
SectionEnd

Section "-MSVC100" MSVC100
ClearErrors
ReadRegDWORD $0 HKLM "Software\Microsoft\DevDiv\vc\Servicing\10.0\RuntimeMinimum" "Install"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the "RuntimeMinimum" key is in "11.0", while "10.0" doesn't have such, so this would give me a false positive.
Also this looks like it would give false positives in general, if the user has VC++ newer than 2010, but not 2010 (just guessing here).

I would suggest looking at #8360, because it checks for the exact same thing - whether VC++ 2010 or later is installed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is possible with NSIS scripts.

@Mailaender Mailaender closed this Jun 20, 2015
@Mailaender Mailaender deleted the nsis-msvc110 branch June 20, 2015 13:40
@Mailaender
Copy link
Member Author

Also I can't really test this on Linux so someone else may take over who actually uses Windows.

@Mailaender Mailaender mentioned this pull request Jun 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mailaender @pchote @penev92