Added two new difficulties to allies-05a #8359

abcdefg30 · 2015-06-02T12:02:39Z

Also fixed #8353.

Mailaender · 2015-06-03T05:29:08Z

I suggest to only git cherry-pick e1b5b3f into prep-1505.

abcdefg30 · 2015-06-05T12:55:57Z

Updated with suggestions from @Snurre86.
Also added some speech notifications.

abcdefg30 · 2015-06-05T12:57:26Z

Here is also a video from @Snurre86: https://www.youtube.com/watch?v=RUrlddwGN1M&feature=youtu.be

obrakmann · 2015-06-14T08:41:52Z

I've just cherry-picked the first commit into prep.

obrakmann · 2015-06-17T18:22:05Z

mods/ra/maps/allies-05a/allies05a.lua

+			Trigger.OnRemovedFromWorld(Tanya, function()
+				ExtractUnits(ExtractionHeli, exitPos, function()
+
+					Media.PlaySpeechNotification("TanyaRescued")


Fatal Lua Error: [string "BindingSupport.lua"]:30: Unable to convert parameter 0 to Player

You'll notice a pattern here ;)

abcdefg30 · 2015-06-17T18:56:05Z

Derp, fixed.

obrakmann · 2015-06-17T19:20:34Z

mods/ra/maps/allies-05a/AI.lua

-		IdleHunt(unit)
-	end)
+	local units = { }
+	if SendWaterTransports and Utils.RandomInteger(0,1) == 1 then


This will never happen, because Utils.RandomInteger never returns the high value. Yes, it's annoying, but it's too late to change now.

obrakmann · 2015-06-17T19:22:07Z

Looks otherwise good to me. Didn't try the hardest skill in earnest, but "Hard" was doable. 👍

Mailaender · 2015-06-27T15:22:55Z

Crashes when exploding the last SAM site on "Real tough guy":

Fatal Lua Error: [string "BindingSupport.lua"]:30: Uncaught CLR exception at Lua->CLR boundary: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.InvalidOperationException: Actor has multiple traits of type `OpenRA.Mods.Common.Traits.RenderSprites`
  at OpenRA.TraitDictionary+TraitContainer`1[OpenRA.Mods.Common.Traits.RenderSprites].GetOrDefault (UInt32 actor) [0x000b4] in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/TraitDictionary.cs:161 
  at OpenRA.TraitDictionary+TraitContainer`1[OpenRA.Mods.Common.Traits.RenderSprites].Get (UInt32 actor) [0x00003] in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/TraitDictionary.cs:146 
  at OpenRA.TraitDictionary.Get[RenderSprites] (OpenRA.Actor actor) [0x00013] in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/TraitDictionary.cs:96 
  at OpenRA.Actor.Trait[RenderSprites] () [0x0000d] in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Actor.cs:212 
  at OpenRA.Mods.Common.Traits.WithSpriteBody..ctor (OpenRA.ActorInitializer init, OpenRA.Mods.Common.Traits.WithSpriteBodyInfo info, System.Func`1 baseFacing) [0x00027] in /home/matthias/Entwicklung/OpenRA/OpenRA.Mods.Common/Traits/Render/WithSpriteBody.cs:55 
  at OpenRA.Mods.Common.Traits.WithFacingSpriteBody..ctor (OpenRA.ActorInitializer init, OpenRA.Mods.Common.Traits.WithFacingSpriteBodyInfo info) [0x00009] in /home/matthias/Entwicklung/OpenRA/OpenRA.Mods.Common/Traits/Render/WithFacingSpriteBody.cs:44 
  at OpenRA.Mods.Common.Traits.WithFacingSpriteBodyInfo.Create (OpenRA.ActorInitializer init) [0x00003] in /home/matthias/Entwicklung/OpenRA/OpenRA.Mods.Common/Traits/Render/WithFacingSpriteBody.cs:21 
  at OpenRA.Actor..ctor (OpenRA.World world, System.String name, OpenRA.Primitives.TypeDictionary initDict) [0x000c8] in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Actor.cs:95 
  at OpenRA.World.CreateActor (Boolean addToWorld, System.String name, OpenRA.Primitives.TypeDictionary initDict) [0x00004] in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/World.cs:241 
  at OpenRA.Mods.Common.Scripting.ReinforcementsGlobal.CreateActor (OpenRA.Player owner, System.String actorType, Boolean addToWorld, Nullable`1 entryLocation, Nullable`1 nextLocation) [0x00131] in /home/matthias/Entwicklung/OpenRA/OpenRA.Mods.Common/Scripting/Global/ReinforcementsGlobal.cs:50 
  at OpenRA.Mods.Common.Scripting.ReinforcementsGlobal.ReinforceWithTransport (OpenRA.Player owner, System.String actorType, System.String[] cargoTypes, OpenRA.CPos[] entryPath, OpenRA.CPos[] exitPath, Eluant.LuaFunction actionFunc, Eluant.LuaFunction exitFunc) [0x0004f] in /home/matthias/Entwicklung/OpenRA/OpenRA.Mods.Common/Scripting/Global/ReinforcementsGlobal.cs:112 
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00054] in /home/abuild/rpmbuild/BUILD/mono-4.0.2/mcs/class/corlib/System.Reflection/MonoMethod.cs:230 
  --- End of inner exception stack trace ---
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00069] in /home/abuild/rpmbuild/BUILD/mono-4.0.2/mcs/class/corlib/System.Reflection/MonoMethod.cs:238 
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in /home/abuild/rpmbuild/BUILD/mono-4.0.2/mcs/class/corlib/System.Reflection/MethodBase.cs:114 
  at OpenRA.Scripting.ScriptMemberWrapper.Invoke (Eluant.LuaVararg args) [0x00101] in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Scripting/ScriptMemberWrapper.cs:70 
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00054] in /home/abuild/rpmbuild/BUILD/mono-4.0.2/mcs/class/corlib/System.Reflection/MonoMethod.cs:230 
  --- End of inner exception stack trace ---
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00069] in /home/abuild/rpmbuild/BUILD/mono-4.0.2/mcs/class/corlib/System.Reflection/MonoMethod.cs:238 
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in /home/abuild/rpmbuild/BUILD/mono-4.0.2/mcs/class/corlib/System.Reflection/MethodBase.cs:114 
  at Eluant.LuaRuntime+MethodWrapper.Invoke (System.Object[] parms) [0x00000] in <filename unknown>:0 
  at Eluant.LuaRuntime.MakeManagedCall (IntPtr state, Eluant.MethodWrapper wrapper) [0x00000] in <filename unknown>:0 
   at OpenRA.Scripting.ScriptContext.FatalError(System.String message)
   at OpenRA.Mods.Common.Scripting.TriggerGlobal+<OnAllKilled>c__AnonStorey1.<>m__0(OpenRA.Actor m)
   at OpenRA.Mods.Common.Scripting.ScriptTriggers.Killed(OpenRA.Actor self, OpenRA.Traits.AttackInfo e)
   at OpenRA.Traits.Health.InflictDamage(OpenRA.Actor self, OpenRA.Actor attacker, Int32 damage, OpenRA.GameRules.DamageWarhead warhead, Boolean ignoreModifiers)
   at OpenRA.Actor.Kill(OpenRA.Actor attacker)
   at OpenRA.Mods.Common.Traits.Demolishable.Demolish(OpenRA.Actor self, OpenRA.Actor saboteur)
   at OpenRA.Mods.Common.Activities.Demolish+<OnInside>c__AnonStorey2+<OnInside>c__AnonStorey1.<>m__3(IDemolishable d)
   at OpenRA.Exts.Do(IEnumerable`1 e, System.Action`1 fn)
   at OpenRA.Mods.Common.Activities.Demolish+<OnInside>c__AnonStorey2+<OnInside>c__AnonStorey1.<>m__1()
   at OpenRA.Effects.DelayedAction.<Tick>m__0(OpenRA.World w)
   at OpenRA.World.Tick()
   at OpenRA.Game.InnerLogicTick(OpenRA.Network.OrderManager orderManager)
   at OpenRA.Game.LogicTick()
   at OpenRA.Game.Loop()
   at OpenRA.Game.Run()
   at OpenRA.Program.Run(System.String[] args)
   at OpenRA.Program.Main(System.String[] args)

abcdefg30 · 2015-06-27T16:24:13Z

Should be fixed now.

Mailaender · 2015-06-30T19:52:46Z

Otherwise works as promised. ✅

abcdefg30 · 2015-07-01T16:41:59Z

Updated.

Mailaender · 2015-07-01T16:55:38Z

Needs a rebase due to #8416.

abcdefg30 · 2015-07-01T17:01:52Z

Rebased.

Mailaender · 2015-07-01T20:03:28Z

Most creative super hard difficulty yet!

Works as promised. ✅

Added two new difficulties to allies-05a

Mailaender · 2015-07-01T20:11:26Z

Changelog

Mailaender added the PR: For stable label Jun 3, 2015

abcdefg30 force-pushed the difficulty branch from 3d77c6c to d2df0df Compare June 5, 2015 12:51

penev92 removed the PR: For stable label Jun 16, 2015

obrakmann reviewed Jun 17, 2015
View reviewed changes

Mailaender added the PR: Changes requested label Jun 17, 2015

abcdefg30 force-pushed the difficulty branch from d2df0df to 6e0937f Compare June 17, 2015 18:55

abcdefg30 removed the PR: Changes requested label Jun 17, 2015

obrakmann reviewed Jun 17, 2015
View reviewed changes

obrakmann added PR: Changes requested PR: Needs +2 labels Jun 17, 2015

abcdefg30 force-pushed the difficulty branch from 6e0937f to 5285b1c Compare June 17, 2015 19:24

abcdefg30 removed the PR: Changes requested label Jun 17, 2015

obrakmann added the PR: Rebase me! label Jun 22, 2015

abcdefg30 force-pushed the difficulty branch from 5285b1c to 76a03c4 Compare June 22, 2015 19:44

abcdefg30 removed the PR: Rebase me! label Jun 22, 2015

Mailaender added the PR: Changes requested label Jun 27, 2015

abcdefg30 force-pushed the difficulty branch from 76a03c4 to 711591d Compare June 27, 2015 16:24

abcdefg30 removed the PR: Changes requested label Jun 27, 2015

abcdefg30 force-pushed the difficulty branch from 711591d to d77f73f Compare July 1, 2015 16:41

Mailaender added the PR: Rebase me! label Jul 1, 2015

abcdefg30 added 2 commits July 1, 2015 18:59

Add MustBeDestroyed: to FCOM

39a297d

Added two new difficulties to allies-05a

ae955a2

abcdefg30 force-pushed the difficulty branch from d77f73f to ae955a2 Compare July 1, 2015 17:01

abcdefg30 removed the PR: Rebase me! label Jul 1, 2015

Mailaender added a commit that referenced this pull request Jul 1, 2015

Merge pull request #8359 from abcdefg30/difficulty

79d00b2

Added two new difficulties to allies-05a

Mailaender merged commit 79d00b2 into OpenRA:bleed Jul 1, 2015

abcdefg30 deleted the difficulty branch July 1, 2015 20:09

Mailaender mentioned this pull request Jul 1, 2015

Port missions to the new Lua API #5490

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added two new difficulties to allies-05a #8359

Added two new difficulties to allies-05a #8359

abcdefg30 commented Jun 2, 2015

Mailaender commented Jun 3, 2015

abcdefg30 commented Jun 5, 2015

abcdefg30 commented Jun 5, 2015

obrakmann commented Jun 14, 2015

obrakmann Jun 17, 2015

abcdefg30 commented Jun 17, 2015

obrakmann Jun 17, 2015

abcdefg30 Jun 17, 2015

obrakmann commented Jun 17, 2015

Mailaender commented Jun 27, 2015

abcdefg30 commented Jun 27, 2015

Mailaender commented Jun 30, 2015

abcdefg30 commented Jul 1, 2015

Mailaender commented Jul 1, 2015

abcdefg30 commented Jul 1, 2015

Mailaender commented Jul 1, 2015

Mailaender commented Jul 1, 2015

Added two new difficulties to allies-05a #8359

Added two new difficulties to allies-05a #8359

Conversation

abcdefg30 commented Jun 2, 2015

Mailaender commented Jun 3, 2015

abcdefg30 commented Jun 5, 2015

abcdefg30 commented Jun 5, 2015

obrakmann commented Jun 14, 2015

obrakmann Jun 17, 2015

Choose a reason for hiding this comment

abcdefg30 commented Jun 17, 2015

obrakmann Jun 17, 2015

Choose a reason for hiding this comment

abcdefg30 Jun 17, 2015

Choose a reason for hiding this comment

obrakmann commented Jun 17, 2015

Mailaender commented Jun 27, 2015

abcdefg30 commented Jun 27, 2015

Mailaender commented Jun 30, 2015

abcdefg30 commented Jul 1, 2015

Mailaender commented Jul 1, 2015

abcdefg30 commented Jul 1, 2015

Mailaender commented Jul 1, 2015

Mailaender commented Jul 1, 2015