Mobile Blocking Refactor #9105
Merged
Mobile Blocking Refactor #9105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he start. When transient actors checks are not needed, all control flows in the method return true. Therefore, we can return true directly in this case. Checking this condition is cheaper than checking for a free sub-cell, so this allows us a faster exit when we don't need to check for transient actors.
| return false; | ||
|
|
||
| // If we cannot crush the other actor in our way, we are blocked. | ||
| if (self == null || Crushes == null || Crushes.Length == 0) |
There was a problem hiding this comment.
The thing that irks me about this line is that we are checking this multiple times in CanMoveFreelyInto even though it doesn't ever change... I guess it is negligible but it still irks me.
There was a problem hiding this comment.
Whilst it's a touch irksome, it's certainly not a performance issue compared to grovelling through the various dictionary lookups.
|
Nudging and crushing seems to work as it did before. ✅ |
|
👍 good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring in Mobile.cs of the logic used to determine if actors block movement.
This centralises some duplicated logic in
CanMoveFreelyIntoand intoGetAvailableSubCellinto a new method and makes some minor changes to squeeze out a bit more performance as the pathfinder callsCanMoveFreelyIntofrequently.This is intended to have no impact on the output of these functions. This means for testing you could record a game on bleed and replaying it with this PR should not desync. That's how I tested it.