Fixed TS crane overlay's last frame hiding idle overlay #9377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are all the other overlay traits going to have similar problems? |
| @@ -35,6 +35,7 @@ public class WithBuildingPlacedOverlay : INotifyBuildComplete, INotifySold, INot | |||
| { | |||
| readonly Animation overlay; | |||
| bool buildComplete; | |||
| bool hide; | |||
There was a problem hiding this comment.
Might be a bit more consistent with other code to call this visible and invert the checks.
Possibly. I'll take a look. |
reaperrr
force-pushed
the
fix-bldplace-overlay
branch
from
5b9712c
to
e9c2c4b
Compare
This was an idle animation in the original, and this and "platform" cannot be displayed at the same time anyway. Also increased Tick rate to match idle light.
reaperrr
force-pushed
the
fix-bldplace-overlay
branch
from
e9c2c4b
to
4aaa628
Compare
|
Fixed |
|
👍 As a nice side effect this also makes the cloaking look better. |
|
Confirmed fixes 👍. Thanks. |
pchote
added a commit
that referenced
this pull request
Sep 20, 2015
Fixed TS crane overlay's last frame hiding idle overlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS crane overlay's last frame no longer overlaps idle overlay.
WithBuildingPlacedOverlayis now only visible while playing the animation, rather than sticking around.Fixes #9319.