Unhardcode and document things in Chronoshiftable #9982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems OK 👍 |
| @@ -41,6 +49,7 @@ public Chronoshiftable(ActorInitializer init, ChronoshiftableInfo info) | |||
| { | |||
| this.info = info; | |||
| self = init.Self; | |||
| iPositional = self.TraitOrDefault<IPositionable>(); | |||
There was a problem hiding this comment.
I assume this would need #8848 to work independent from trait ordering.
There was a problem hiding this comment.
Please implement INotifyCreated and move this there to avoid trait-initialization-order bugs.
abcdefg30
force-pushed
the
chronodesc
branch
from
d0a4519
to
6cd8649
Compare
|
Updated. |
| public readonly bool ExplodeInstead = false; | ||
| public readonly string ChronoshiftSound = "chrono2.aud"; | ||
|
|
||
| [Desc("Should the actor return to its location after the chronoshift weared out?.")] |
There was a problem hiding this comment.
Repeating the vocabulary used in the parameter often doesn't really help explain things.
There was a problem hiding this comment.
Certainly, but location is completely incorrect.
There was a problem hiding this comment.
I read it as s/location/origin question mark. Not ?. being a syntax error. Try being more verbose next time. Especially when you have to vertically scroll to see the problem.
Mailaender
added a commit
that referenced
this pull request
Nov 22, 2015
Unhardcode and document things in Chronoshiftable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.