Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clear-rough terrain #86

Closed
wants to merge 2 commits into from
Closed

Conversation

dderevjanik
Copy link

@dderevjanik dderevjanik commented May 20, 2018

Hi,
I added new terrain type clear-rough (name is derived from transition between clear and rough)
Currently, there are several issues (bad pixels) with tiles, but I'm planning to fix them later. Also, I consider to adding more terrain types in near future :) .

Ingame screenshot:

image

There's no map with my tiles, yet

@MustaphaTR
Copy link
Member

Can you update the OH Gap map? That's a D2k map that had sand-rough terrain, but i used Dunes instead on the D2 conversion. It would better to make the map as in D2k imo.

@dderevjanik
Copy link
Author

Not sure if I understand correctly... Should I replace all dunes with new clear-rough terrain ?

@MustaphaTR
Copy link
Member

Yes, replace all the dunes (the terrain that units move slower) with clear-rough.

@dderevjanik
Copy link
Author

Ok, I will do that :)

@dderevjanik
Copy link
Author

@MustaphaTR map updated

image

@evgeniysergeev
Copy link
Collaborator

Asset licensing is serious business. In a multi-billion dollar industry where thousands of hands come together under a single banner to create a single product, there should be no doubt as to who owns the art, code, and sounds associated with a game.
from here: https://gamedevelopment.tutsplus.com/articles/understanding-licenses-or-can-i-use-this-asset-in-my-game--cms-22510

There no modified assets at this point in d2. And link to original game archive not published in wiki. Players should obtain their copy of assets. Logo screen it is not just a bitmap it uses special loader to load original image and don't distribute modified or original image. It should be obtained by player.
The same applied for every unit in game. It was sometimes not trivial to load original images, but loaders do that instead of converting everything to bmp or shp. because it is bad idea to publish assets from original game.

I think it is bad idea to do so. May be it is good idea to enhance the game, but not in the way of modify original assets.

This mod will be close to original game with some small enhancements. This is why I don't want to merge this pull request.

Also, original assets allow to easy select needed tile for corners. this added tiles create chaos in this. then rough is near sand, what tile should engine use: rough+rock (like now) or rough+sand?

@evgeniysergeev
Copy link
Collaborator

d2 mod should be VERY close to original game. some enhancements possible but not in assets. not in sounds or images. this was original idea of d2 mod

@dderevjanik
Copy link
Author

I wanted to make something similar to what I did for d2k. You can find new tiles in d2k mod.
At the end, it is always decision for map maker if those tiles will be included in map or not. Everything else (like campaign, units, buildings, etc.) stays VERY close to original game.

Feel free to open this PR anytime...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants