Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the TEMPERATE map import and clean up the maps #30

Merged
merged 6 commits into from
Jan 16, 2016

Conversation

Mailaender
Copy link
Member

Somehow the tileset was called TEMPERAT while all the original maps define TEMPERATE compare with http://modenc.renegadeprojects.com/Theatres as well. I fixed that and replaced all junk maps with proper ones where no actors are missing using the latest version of the map importer OpenRA/OpenRA#10397 which includes several fixes such as proper map boundaries and global lighting.

@phrohdoh
Copy link
Member

Note for reviewers: This also adds maps (which the title does not mention) without screenshots, and I'm willing to bet that ore creation isn't correct on them (it hasn't been in the past unfortunately).

@GraionDilach
Copy link
Contributor

The ore issues are caused by Westwood mappers using third ore instead of first one.

See http://modenc.renegadeprojects.com/Image#In_YR and https://github.com/Phrohdoh/oramod-ra2/blob/master/extra-files/rules.ini#L1523 regarding the problem. (The TIB02 entries in art.ini shares the image with the TIB entries where's this confusion comes. ModEnc uses the internal indexes in the article, which starts from #0, the additional offset differences are caused by WW skipping index #40 and #41 in rules.ini).

These will probably need a fork of the TS map importer branch with #127-#139 also being converted to Ore being the sole change.

@abcdefg30
Copy link
Member

Amazonas delta looks good to me:
openra-2016-01-13t200641z
openra-2016-01-13t200645z
Although this looks like a small tile issue to me:
openra-2016-01-13t200649z
Snow Valley, Heck Freezes Over and Powder Keg look good to me, too:
openra-2016-01-13t200854z
openra-2016-01-13t201558z
openra-2016-01-13t201740z
DEFCON 6 has no ore (just some gems).

@Mailaender
Copy link
Member Author

The ore issues are caused by Westwood mappers using third ore instead of first one.

Thanks for the hint. I assumed that it could be an error in the terrain tiles where resource growth isn't allowed as the drills also don't seem to work, but didn't investigate it further.

@Mailaender
Copy link
Member Author

Rebased to also account for recently added sentry turret. #9

@GraionDilach
Copy link
Contributor

Come to think of it, that's also possible, Ore and Gems are only allowed on Clear, while they were also available on Rough atleast - notsure regarding DirtRoad.

@abcdefg30
Copy link
Member

Sorry, but needs a rebase.

@Mailaender
Copy link
Member Author

Rebased and added the missing terrain type definition to fix resource seeding:

image

@Mailaender
Copy link
Member Author

Amazonas delta looks good to me:
[...]
Although this looks like a small tile issue to me:
[...]

I removed it again.

@abcdefg30
Copy link
Member

Looks good to me now. 👍 / ✅

abcdefg30 added a commit that referenced this pull request Jan 16, 2016
Fixed the TEMPERATE map import and clean up the maps
@abcdefg30 abcdefg30 merged commit fb81c4b into OpenRA:master Jan 16, 2016
@Mailaender Mailaender deleted the maps branch January 16, 2016 12:43
Mailaender pushed a commit that referenced this pull request May 19, 2016
Fixed the TEMPERATE map import and clean up the maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants