-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extraterrestrial style #21
Conversation
I mean extraterrestrial style. Let me know if there's anything that needs changing, but I think I got everything correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I think I like this better than the original, which sounded a more on the spooky/Halloween side than something from space.
I just think the loop feels a little unpleasant, as the music grows as it progresses and then "resets" all of a sudden at the end, maybe it should slow down on some of the effects before it loops (?). Being a non-musician makes it very hard for me to explain what I want :D
I do get what you mean, ill make it a bit longer to transition back to less distorted and such. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I couldn't tell the difference between the last and penultimate commit, but I like the longer version to loop in a smoother manner and I'm satisfied with the music :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what changed, but it still sounds great :P
haha, the bass that comes in was a bit too harsh for my liking at the start, so I made it so the top-end frequencies come in halfway through the song. Gives a bit more tension. |
The audio file is quite big, it's 20MiB for 3min audio, if we have a few of them then its getting quite big pretty fast, anything we can do about that? Edit: The music is pretty good also. |
The FLAC is just the size of the file in this directory. It gets converted to a OGG Vorbis file. It's being saved in FLAC for if we ever want a higher quality pack option to be available. You can expect the size included in the game to be a bit under 1mb. |
Fair enough |
It would be nice if this could be merged and a new release could be made so this and Blizzard style could be part of the new release. It seems MacOS still has some issues with getting ahold of the OpenMusic and OpenSound files. I believe Linux was fixed with a very recent PR. |
Accidentally rendered with the tail, even though it shouldnt have one. No change in any sounds, this just makes it so it loops correctly.
Let me know if there's anything that needs changing, but I think I got everything correctly.