Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mystic style #46

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Add Mystic style #46

merged 2 commits into from
Sep 1, 2023

Conversation

karst
Copy link
Member

@karst karst commented Jun 26, 2023

Adds Mystic style by @SkyshardMelody.

Need to make sure if the name of the tune is fine or not.

Adds Mystic style by @SkyshardMelody.

Co-Authored-By: SkyshardMelody <127544308+SkyshardMelody@users.noreply.github.com>
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it better than the fantasy theme it is replacing. Not sure about the "mystic" name, but that's a minor thing.

About the author, do they want to keep credits with username?

alternative/openrct2.music.mystic/object.json Outdated Show resolved Hide resolved
@karst
Copy link
Member Author

karst commented Jun 28, 2023

I like it better than the fantasy theme it is replacing. Not sure about the "mystic" name, but that's a minor thing.

Would Mystical be better? I think it might be. I was looking for a good name for it.

About the author, do they want to keep credits with username?

They wanted to get credits with their username, instead of real name.

@IntelOrca
Copy link
Contributor

I think this is a cross between fantasy and mediveval, but not sure how best to describe that cross-genre.

@tupaschoal
Copy link
Member

Maybe something like "heroic"?

@karst
Copy link
Member Author

karst commented Jun 29, 2023

Perhaps "Elven" or something like that?

@tupaschoal
Copy link
Member

I like it

@Broxzier
Copy link
Member

I don't think "Elves" matches the song well enough, especially at the epic part. I get more of a fantasy, medieval, adventurous, fairy tale vibe from it.

Perhaps "Adventure style" would work?

@ZehMatt
Copy link
Member

ZehMatt commented Jun 29, 2023

Perhaps "Elven" or something like that?

Is that even a real genre? I've listened to it and this sounds like some fantasy adventure track.

@tupaschoal
Copy link
Member

Is that even a real genre? I've listened to it and this sounds like some fantasy adventure track.

It's trying to replace fantasy, but for some reason I assumed we were not reusing theme names from vanilla.

@IntelOrca
Copy link
Contributor

@Broxzier I think Adventure style would be something more like the original Wild West track.

@karst
Copy link
Member Author

karst commented Jun 29, 2023

@Broxzier I think Adventure style would be something more like the original Wild West track.

I think Frontier style would be better for that. Adventurer's style could be kinda nice tho, kinda that DnD name to it.

@IntelOrca
Copy link
Contributor

could be kinda nice tho, kinda that DnD name to it.

Wouldn't that be campaign style?

@Broxzier
Copy link
Member

@tupaschoal We're not replacing the original, are we? I still want to use the original one. Or do you mean this would be a fallback track for when the original game isn't linked.

@karst
Copy link
Member Author

karst commented Jun 30, 2023

It's part of the alternative project. For reference, the alternatives are tunes that replace base game music with new songs if the base game isn't installed. Covers replace the masters of old tunes with new (and improved) masters. And additional adds new music without replacing anything.

@karst
Copy link
Member Author

karst commented Jun 30, 2023

Perhaps if we'd call this Elven style we could call the medivial 'Dwarven style'.

@tupaschoal
Copy link
Member

Naming is the least of our concerns here, we can change it later, don't let it hold you back on merging if you need.

@karst karst merged commit e15aba3 into OpenRCT2:master Sep 1, 2023
1 check passed
@karst karst deleted the fantasy branch September 1, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants