Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RMC sounds, audio objects and asset packs #18312

Merged
merged 7 commits into from
Nov 12, 2022
Merged

Add RMC sounds, audio objects and asset packs #18312

merged 7 commits into from
Nov 12, 2022

Conversation

IntelOrca
Copy link
Contributor

No description provided.

@IntelOrca IntelOrca force-pushed the opensounds branch 4 times, most recently from b7e9e5e to d967e48 Compare October 14, 2022 23:49
@IntelOrca IntelOrca marked this pull request as ready for review October 15, 2022 00:25
@karst karst mentioned this pull request Oct 15, 2022
Merged
@karst
Copy link
Member

karst commented Oct 15, 2022 •
edited
Loading

The RMC track friction is not using the correct pitch, it should have the same values as the B&M track friction sound.
auraspecs.rmctest.zip
Use the following assetpack on current develop version to check the difference.
At current commit the sound of RMC track friction sounds like mosquito which is sounds quite annoying, while in the assetpack above it sounds more roaring and epic (deeper). Done

I have made a PR on the objects directory to change the sounds to use the correct track friction see right here OpenRCT2/objects#220
Once this is merged the objects repo will need a new release and that should be pushed with this PR. Done

Lastly the DefaultObjects need to be updated.
In .h that is extern const std::string_view DefaultSelectedObjects[106]; (instead of 103)
And under // Music in .cpp you need to add openrct2.music.acid, openrct2.music.dodgems and openrct2.music.galaxy at line 116.
The three above should also be inserted to RCT12.cpp at line 735 TBD

That's all I have currently found.

@Gymnasiast Gymnasiast self-requested a review October 19, 2022 10:23
@karst
Copy link
Member

karst commented Oct 25, 2022 •
edited
Loading

The only thing I am currently concerned with still is that the music files will be dropped in the build twice rather than the alternative style being able to pull the music from a music object file. Music files are already pretty big as they are and to have them duplicated is kind of a waste of space.
Artifact to show: OpenRCT2 OpenMusic Objects.zip

This could of course be addressed at a later time. But it's definitely something to keep in mind.

@Gymnasiast Gymnasiast added the changelog This issue/PR deserves a changelog entry. label Nov 8, 2022
Gymnasiast
Gymnasiast requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@Gymnasiast Gymnasiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out. The asset download does not seem to work, but installing them manually, I get the lovely Hbyrid RC sounds. So we just have to sort out that bit, I imagine.

@IntelOrca
Copy link
Contributor Author

Tested this out. The asset download does not seem to work, but installing them manually, I get the lovely Hbyrid RC sounds. So we just have to sort out that bit, I imagine.

try now

@karst
Copy link
Member

karst commented Nov 10, 2022

Changelog entry would probably look best like this:

- Feature: [#18312, objects#220, OpenSFX#13] New sound effects for the Hybrid RC & Single Rail RC.
- Feature: [objects#221] Adopt two of Couger's jungle walls as official objects.
- Feature: [OpenSFX#11, OpenMusic#19] Official replacement assetpacks for sound effects & music. 
- Feature: [OpenMusic#14, OpenMusic#15, OpenMusic#18] New music is now available: Galaxy style, Acid style, Dodgems style.

@Gymnasiast Gymnasiast added this to the v0.4.3 milestone Nov 12, 2022
@Gymnasiast Gymnasiast merged commit ae9bf66 into OpenRCT2:develop Nov 12, 2022
@Gymnasiast Gymnasiast deleted the opensounds branch November 12, 2022 18:04
Gymnasiast added a commit that referenced this pull request Dec 14, 2022
@Gymnasiast
Release v0.4.3
285e0fc 
- Feature: [#17782] The Flying Coaster now has access to boosters and can draw outside loops.
- Feature: [#17997] The Log Flume can now draw steep pieces down (if vehicle allows it).
- Feature: [#18312, objects#220, OpenSFX#13] New sound effects for the Hybrid and Single Rail roller coasters.
- Feature: [#18675] [Plugin] Plugins can refer to g2 image icons by name.
- Feature: [objects#173] Add alpine coaster vehicle.
- Feature: [objects#221] Add two extra jungle walls.
- Feature: [objects#225] Add log cabin roofs.
- Feature: [OpenMusic#14, OpenMusic#15, OpenMusic#18] Added Galaxy, Acid and Dodgems ride music styles.
- Improved: [#18013, #18016, #18018, #18019, #18514, objects#224] Added colour presets to Spiral Slide, Dodgems, Boat Hire, Flying Saucers, and Car Ride.
- Improved: [#18024] Clearer error messages when loading incompatible .park files.
- Improved: [#18192] Tycoon Park has been added to the Extras tab.
- Improved: [#18214] Competition scenarios have received their own section.
- Improved: [#18250] Added modern style file and folder pickers on Windows.
- Improved: [#18332] Allow Inverted Roller Coaster to draw boosters.
- Improved: [#18350] Changed ride vehicle list to have less padding.
- Improved: [#18422] Allow adding images to music objects.
- Improved: [#18428] [Plugin] Add widget description interfaces to documentation.
- Improved: [#18487] Mini Helicopters track can now draw spinning tunnels.
- Improved: [#18591] Order RollerCoaster Tycoon 2 scenarios by difficulty.
- Improved: [#18607] A new tab for all UCES Scenarios, if it’s installed.
- Improved: [#18621] OpenGL performance.
- Change: [#17677] Open campaign window from finished campaign news.
- Change: [#17998] Show cursor when using inverted mouse dragging.
- Change: [#18230] Make the large flat to steep pieces available on the corkscrew roller coaster without cheats.
- Change: [#18381] Convert custom invisible paths to the built-in ones.
- Change: [OpenSFX#11, OpenMusic#19] First implementation of official replacement asset packs for sound effects & music.
- Fix: [#1491] Clearance of the Cash Machine is too low (original bug).
- Fix: [#1519] “See-through rides” doesn't affect all rides (original bug).
- Fix: [#6341] “Unlock vehicle limits” does not allow setting fewer vehicles than the vehicle type requires.
- Fix: [#14312] Research ride type message incorrect.
- Fix: [#14425] Ride ratings do not skip unallocated ride ids.
- Fix: [#15969] Guests heading for ride use vanilla behaviour
- Fix: [#17067] Random Staff Patrol Area clicks.
- Fix: [#17316] Sides of River Rapids’ corners overlay other parts of the track.
- Fix: [#17657] When switching from buying land rights to buying construction rights, grid disables and won't re-enable afterwards.
- Fix: [#17763] Missing validation on invalid characters in file name.
- Fix: [#17853] Invention name tears while being dragged.
- Fix: [#18064] Unable to dismiss notification messages.
- Fix: [#18070] Underground entrance/exit shows through terrain walls (original bug).
- Fix: [#18094] Underground shops & facilities don't show when adjacent to non-underground path (original bug).
- Fix: [#18122] Ghosts count towards “Great scenery!” guest thought.
- Fix: [#18134] Underground on-ride photo section partially clips through adjacent terrain edge.
- Fix: [#18244] Invention DragWindow's starting position is inconsistent.
- Fix: [#18245] Guests stopping dead in their tracks at railway crossings.
- Fix: [#18257] Guests ‘waiting’ on extended railway crossings.
- Fix: [#18354] Overwrite alert does not show when save name has different casing on Windows.
- Fix: [#18379] Tunnel entrances for underground Mini Golf Hole E are not rendered correctly.
- Fix: [#18442] About window background is clickable.
- Fix: [#18449] [Plugin] Change type of listview widgets from 'scroll_view' to 'listview'.
- Fix: [#18453] Slow walking guests don't get across level crossings in time.
- Fix: [#18469] Land rights window buttons incorrectly disabled and markers remain visible indefinitely.
- Fix: [#18459] ‘Highlight path issues’ hides fences for paths with additions.
- Fix: [#18552] Trains clipping through helixes.
- Fix: [#18576] Cannot open parks with certain types of corrupt tile elements.
- Fix: [#18606] JSON objects do not take priority over the DAT files they supersede.
- Fix: [#18620] [Plugin] Crash when reading widget properties from windows that have both static and tab widgets.
- Fix: [#18653] Negative ratings multipliers do not appear in Vehicle tab.
- Fix: [#18696] Construction rights cannot be viewed after all are purchased.
- Fix: [#18720] Upwards helix is enabled for the Alpine Coaster, even when cheats are off.
- Fix: [#18755] Ferris Wheel and Circus ghosts not coloured correctly.
- Fix: [#18802] Game could crash when determining if a mechanic is heading to fix the ride blocking the path.
@Broxzier Broxzier mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gymnasiast Gymnasiast Gymnasiast approved these changes

Assignees
No one assigned
Labels
changelog This issue/PR deserves a changelog entry.
Projects
None yet
Milestone
v0.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@IntelOrca @karst @Gymnasiast