Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Random" title music could still attempt to play RCT1 after it gets deselected #20262

Closed
Broxzier opened this issue May 21, 2023 · 3 comments
Closed
Labels
bug Something went wrong.
Milestone

Comments

@Broxzier
Copy link
Member

Broxzier commented May 21, 2023

Operating System

Windows 10 x64

OpenRCT2 build

OpenRCT2, v0.4.5 (76ca840) provided by GitHub

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

No response

Describe the issue

If the player then removes the link to RCT1 after having set the title music to random, there's a chance that the game attempts to play the RCT1 theme. Choosing the random title theme was only available when RCT1 was linked, so not really something players would do, but now with the official title sequence added, the random option is available even when RCT1 is not linked. Players are more likely to bump into this issue now.

Steps to reproduce

  1. Link RCT1 in the options window
  2. Select "Random" title music
  3. Restart the game (a few times)
  4. Notice silence - the game must've picked the RCT1 title music which is not available.

Attachments

No response

@Broxzier Broxzier added the bug Something went wrong. label May 21, 2023
@Broxzier Broxzier added this to the v0.4.6 milestone May 21, 2023
Broxzier added a commit to Broxzier/OpenRCT2 that referenced this issue May 21, 2023
ZehMatt added a commit that referenced this issue May 26, 2023
…e-silence

Fix #20262: random title theme can pick RCT1 when unavailable
@karst
Copy link
Member

karst commented May 26, 2023

was this present before the new theme was added? If yes the changelog entry is valid, otherwise, if introduced with the new theme that changelog entry can be removed.

@Broxzier
Copy link
Member Author

Broxzier commented May 26, 2023

Yes, 76ca840 is the release commit.

@karst
Copy link
Member

karst commented May 26, 2023

okay good!

BarryJRowe pushed a commit to BarryJRowe/OpenRCT2 that referenced this issue May 30, 2023
janisozaur added a commit that referenced this issue Sep 3, 2023
- Feature: [#15660] Ability to show window buttons on the left.
- Feature: [#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [#20119, #20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [#20393, #20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [#19735] Server unable to advertise to master server after a connection loss.
- Fix: [#19822] Tile inspector does not deep copy banners.
- Fix: [#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [#20089] Potential crash when a window is closed from another window.
- Fix: [#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [#20310] Map animations are not created on the title screen.
- Fix: [#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [#20361] Crash when using random map generation.
- Fix: [#20364] Adding too much money with cheats causes an overflow.
- Fix: [#20365] Money cheat input does not support negative values.
- Fix: [#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [#20413] Crash when attempting to navigate an empty console history.
- Fix: [#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [#20429] Error window tooltip not closing after 8 seconds.
- Fix: [#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [#20484] Console caret not properly updated when using command history.
- Fix: [#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [#20543] Crash using show segments height from debug paint options.
- Fix: [#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [#20659] Phantom rides remain when closing construction window while paused.
- Fix: [#20672] Maze ghost elements incorrectly displayed.
- Fix: [#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [#20739] Build version info on title screen leaving stray pixels when the camera is moved.
krrg pushed a commit to krrg/OpenRCT2 that referenced this issue Sep 14, 2023
- Feature: [OpenRCT2#15660] Ability to show window buttons on the left.
- Feature: [OpenRCT2#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [OpenRCT2#20119, OpenRCT2#20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [OpenRCT2#20393, OpenRCT2#20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [OpenRCT2#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [OpenRCT2#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [OpenRCT2#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [OpenRCT2#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [OpenRCT2#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [OpenRCT2#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [OpenRCT2#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [OpenRCT2#19735] Server unable to advertise to master server after a connection loss.
- Fix: [OpenRCT2#19822] Tile inspector does not deep copy banners.
- Fix: [OpenRCT2#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [OpenRCT2#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [OpenRCT2#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [OpenRCT2#20089] Potential crash when a window is closed from another window.
- Fix: [OpenRCT2#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [OpenRCT2#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [OpenRCT2#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [OpenRCT2#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [OpenRCT2#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [OpenRCT2#20310] Map animations are not created on the title screen.
- Fix: [OpenRCT2#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [OpenRCT2#20361] Crash when using random map generation.
- Fix: [OpenRCT2#20364] Adding too much money with cheats causes an overflow.
- Fix: [OpenRCT2#20365] Money cheat input does not support negative values.
- Fix: [OpenRCT2#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [OpenRCT2#20413] Crash when attempting to navigate an empty console history.
- Fix: [OpenRCT2#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [OpenRCT2#20429] Error window tooltip not closing after 8 seconds.
- Fix: [OpenRCT2#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [OpenRCT2#20484] Console caret not properly updated when using command history.
- Fix: [OpenRCT2#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [OpenRCT2#20543] Crash using show segments height from debug paint options.
- Fix: [OpenRCT2#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [OpenRCT2#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [OpenRCT2#20659] Phantom rides remain when closing construction window while paused.
- Fix: [OpenRCT2#20672] Maze ghost elements incorrectly displayed.
- Fix: [OpenRCT2#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [OpenRCT2#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [OpenRCT2#20739] Build version info on title screen leaving stray pixels when the camera is moved.
Realsteel89 pushed a commit to Realsteel89/OpenRCT2 that referenced this issue Oct 10, 2023
- Feature: [OpenRCT2#15660] Ability to show window buttons on the left.
- Feature: [OpenRCT2#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [OpenRCT2#20119, OpenRCT2#20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [OpenRCT2#20393, OpenRCT2#20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [OpenRCT2#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [OpenRCT2#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [OpenRCT2#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [OpenRCT2#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [OpenRCT2#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [OpenRCT2#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [OpenRCT2#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [OpenRCT2#19735] Server unable to advertise to master server after a connection loss.
- Fix: [OpenRCT2#19822] Tile inspector does not deep copy banners.
- Fix: [OpenRCT2#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [OpenRCT2#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [OpenRCT2#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [OpenRCT2#20089] Potential crash when a window is closed from another window.
- Fix: [OpenRCT2#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [OpenRCT2#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [OpenRCT2#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [OpenRCT2#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [OpenRCT2#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [OpenRCT2#20310] Map animations are not created on the title screen.
- Fix: [OpenRCT2#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [OpenRCT2#20361] Crash when using random map generation.
- Fix: [OpenRCT2#20364] Adding too much money with cheats causes an overflow.
- Fix: [OpenRCT2#20365] Money cheat input does not support negative values.
- Fix: [OpenRCT2#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [OpenRCT2#20413] Crash when attempting to navigate an empty console history.
- Fix: [OpenRCT2#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [OpenRCT2#20429] Error window tooltip not closing after 8 seconds.
- Fix: [OpenRCT2#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [OpenRCT2#20484] Console caret not properly updated when using command history.
- Fix: [OpenRCT2#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [OpenRCT2#20543] Crash using show segments height from debug paint options.
- Fix: [OpenRCT2#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [OpenRCT2#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [OpenRCT2#20659] Phantom rides remain when closing construction window while paused.
- Fix: [OpenRCT2#20672] Maze ghost elements incorrectly displayed.
- Fix: [OpenRCT2#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [OpenRCT2#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [OpenRCT2#20739] Build version info on title screen leaving stray pixels when the camera is moved.
Realsteel89 pushed a commit to Realsteel89/OpenRCT2 that referenced this issue Oct 15, 2023
- Feature: [OpenRCT2#15660] Ability to show window buttons on the left.
- Feature: [OpenRCT2#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [OpenRCT2#20119, OpenRCT2#20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [OpenRCT2#20393, OpenRCT2#20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [OpenRCT2#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [OpenRCT2#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [OpenRCT2#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [OpenRCT2#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [OpenRCT2#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [OpenRCT2#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [OpenRCT2#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [OpenRCT2#19735] Server unable to advertise to master server after a connection loss.
- Fix: [OpenRCT2#19822] Tile inspector does not deep copy banners.
- Fix: [OpenRCT2#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [OpenRCT2#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [OpenRCT2#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [OpenRCT2#20089] Potential crash when a window is closed from another window.
- Fix: [OpenRCT2#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [OpenRCT2#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [OpenRCT2#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [OpenRCT2#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [OpenRCT2#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [OpenRCT2#20310] Map animations are not created on the title screen.
- Fix: [OpenRCT2#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [OpenRCT2#20361] Crash when using random map generation.
- Fix: [OpenRCT2#20364] Adding too much money with cheats causes an overflow.
- Fix: [OpenRCT2#20365] Money cheat input does not support negative values.
- Fix: [OpenRCT2#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [OpenRCT2#20413] Crash when attempting to navigate an empty console history.
- Fix: [OpenRCT2#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [OpenRCT2#20429] Error window tooltip not closing after 8 seconds.
- Fix: [OpenRCT2#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [OpenRCT2#20484] Console caret not properly updated when using command history.
- Fix: [OpenRCT2#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [OpenRCT2#20543] Crash using show segments height from debug paint options.
- Fix: [OpenRCT2#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [OpenRCT2#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [OpenRCT2#20659] Phantom rides remain when closing construction window while paused.
- Fix: [OpenRCT2#20672] Maze ghost elements incorrectly displayed.
- Fix: [OpenRCT2#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [OpenRCT2#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [OpenRCT2#20739] Build version info on title screen leaving stray pixels when the camera is moved.
AT41 pushed a commit to AT41/OpenRCT2 that referenced this issue Dec 24, 2023
- Feature: [OpenRCT2#15660] Ability to show window buttons on the left.
- Feature: [OpenRCT2#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [OpenRCT2#20119, OpenRCT2#20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [OpenRCT2#20393, OpenRCT2#20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [OpenRCT2#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [OpenRCT2#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [OpenRCT2#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [OpenRCT2#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [OpenRCT2#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [OpenRCT2#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [OpenRCT2#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [OpenRCT2#19735] Server unable to advertise to master server after a connection loss.
- Fix: [OpenRCT2#19822] Tile inspector does not deep copy banners.
- Fix: [OpenRCT2#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [OpenRCT2#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [OpenRCT2#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [OpenRCT2#20089] Potential crash when a window is closed from another window.
- Fix: [OpenRCT2#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [OpenRCT2#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [OpenRCT2#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [OpenRCT2#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [OpenRCT2#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [OpenRCT2#20310] Map animations are not created on the title screen.
- Fix: [OpenRCT2#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [OpenRCT2#20361] Crash when using random map generation.
- Fix: [OpenRCT2#20364] Adding too much money with cheats causes an overflow.
- Fix: [OpenRCT2#20365] Money cheat input does not support negative values.
- Fix: [OpenRCT2#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [OpenRCT2#20413] Crash when attempting to navigate an empty console history.
- Fix: [OpenRCT2#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [OpenRCT2#20429] Error window tooltip not closing after 8 seconds.
- Fix: [OpenRCT2#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [OpenRCT2#20484] Console caret not properly updated when using command history.
- Fix: [OpenRCT2#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [OpenRCT2#20543] Crash using show segments height from debug paint options.
- Fix: [OpenRCT2#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [OpenRCT2#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [OpenRCT2#20659] Phantom rides remain when closing construction window while paused.
- Fix: [OpenRCT2#20672] Maze ghost elements incorrectly displayed.
- Fix: [OpenRCT2#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [OpenRCT2#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [OpenRCT2#20739] Build version info on title screen leaving stray pixels when the camera is moved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong.
Projects
None yet
Development

No branches or pull requests

2 participants