Introduce WINDOW_SHIM define #11653
Merged
Introduce WINDOW_SHIM define #11653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gymnasiast
force-pushed
the
refactor/window-skeleton
branch
from
01df905
to
174c3e9
Compare
Gymnasiast
commented
May 5, 2020
Broxzier
reviewed
May 6, 2020
|
For moving the close box. Well all windows (some probably already do) should be calling a common method for resizing those skeleton (or shim as I call them) widgets. In that common method, it could change the position of the close button based on user preference. |
|
It was my intention to create such a function, yes, especially since it avoids a lot of code duplication, even without the left/right handling. Is it ok if I leave that for another PR, or do you want me to address it in this one? Also, if you think "shim" is a better name than "skeleton": I have no problem changing it. |
Yes, I didn't expect you to do this now. |
Closed
Gymnasiast
force-pushed
the
refactor/window-skeleton
branch
from
174c3e9
to
e64b26d
Compare
Gymnasiast
commented
May 9, 2020
Gymnasiast
commented
May 9, 2020
Gymnasiast
force-pushed
the
refactor/window-skeleton
branch
from
e64b26d
to
df5c789
Compare
Gymnasiast
changed the title
Gymnasiast
commented
May 9, 2020
Gymnasiast
commented
May 9, 2020
Gymnasiast
force-pushed
the
refactor/window-skeleton
branch
from
df5c789
to
b942d24
Compare
IntelOrca
approved these changes
May 9, 2020
tupaschoal
approved these changes
May 10, 2020
Gymnasiast
added a commit
to Gymnasiast/OpenRCT2
that referenced
this pull request
May 12, 2020
Text Input uses one colour, specifically the body colour of the calling window. This was previously handles by a modified window shim, but OpenRCT2#11653 changed this and this window now uses the standard window shim. This is why it now needs to change the colour assignment.
Gymnasiast
added a commit
that referenced
this pull request
May 12, 2020
Text Input uses one colour, specifically the body colour of the calling window. This was previously handles by a modified window shim, but #11653 changed this and this window now uses the standard window shim. This is why it now needs to change the colour assignment.
rdbaris
pushed a commit
to rdbaris/OpenRCT2
that referenced
this pull request
Jun 7, 2020
Text Input uses one colour, specifically the body colour of the calling window. This was previously handles by a modified window shim, but OpenRCT2#11653 changed this and this window now uses the standard window shim. This is why it now needs to change the colour assignment.
This was referenced Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #10133. It does not include the ifdefs to move the close box to the left, as that bit needs a rethink anyway.