-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move UI exclusive string ids to UiStringIds.h #22016
Move UI exclusive string ids to UiStringIds.h #22016
Conversation
a8ef34c
to
4214bdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see the unrelated changes taken out.
These changes are the result of |
bbd97c1
to
d26bb53
Compare
Maybe they shouldn’t be in an enum at all, but be declared as regular constants. But that might be a step too far for this PR? |
It's worth exploring alternatives, such as making them namespaced instead (e.g. Thankfully, there are only 11 ternaries affected in the entire codebase, so it is easy enough to address the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a fan of some of the changes, but I’m not dying on Ternary Hill tonight.
d26bb53
to
b3b62c8
Compare
This moves string ids that are only used in UI context to a new file, UiStringIds.h. The main benefit of this is not having to recompile all of
libopenrct2
whenever a string is added in the UI.As with #22010, the new file was generated using Python to prevent any errors as a result of manual copy pasting. However, some manual touch-ups were still needed due to duplicate definitions, and
-Wdeprecated-anon-enum-enum-conversion
.