Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Reconciliation services can be added multiple times #5964

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Fix: Reconciliation services can be added multiple times #5964

merged 6 commits into from
Jul 10, 2023

Conversation

tsukipedia
Copy link
Contributor

Fixes #5926

Changes proposed in this pull request:

  • Add validation to check if service URL exists in the url map of the reconciliation manager

@github-actions github-actions bot added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features labels Jul 6, 2023
@tsukipedia tsukipedia marked this pull request as draft July 6, 2023 21:33
@tsukipedia tsukipedia mentioned this pull request Jul 6, 2023
Closed
@tsukipedia tsukipedia marked this pull request as ready for review July 7, 2023 05:24
wetneb
wetneb requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tsukipedia, thank you so much for this PR!

It's kind of you to have provided the translations of the message you introduced, but we try to make sure those messages are only edited by people who are confident in those languages. Automated translations are not always of great quality. So in a PR like this I would expect that you only insert the English translation: the other translations will be added by translators via Weblate. If your native language is not English it's fine if you also add a translation for that language in the same go.

main/webapp/modules/core/scripts/reconciliation/recon-manager.js Show resolved Hide resolved
main/webapp/modules/core/langs/translation-en.json Outdated Show resolved Hide resolved
@tsukipedia
PR review changes
64f29fd 
- add return statement
- change error message
wetneb
wetneb approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@wetneb wetneb merged commit 951173e into OpenRefine:master Jul 10, 2023
@tsukipedia tsukipedia deleted the issue-5926-prevent-recon-services-dupes branch July 10, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

@tfmorris tfmorris tfmorris approved these changes

Assignees
No one assigned
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconciliation services can be added multiple times
3 participants
@tsukipedia @tfmorris @wetneb