Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.2 - Blacklist #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

paradiscorentin
Copy link

Hello,
I've added a new module to Opensips-cp.

This blacklist manager allows you to read, insert and edit entries in the database.
It checks if the admin has read-only or read-write permissions to allow him to add / edit entries.
With this tool you can also reload the global blacklist cache with an "apply changes" button.

Corentin Paradis added 4 commits June 16, 2016 16:53
We can now enter every domain we want instead of picking a domain in a
list
@bogdan-iancu bogdan-iancu added this to the 6.2 milestone Jun 21, 2016
@bogdan-iancu bogdan-iancu self-assigned this Jun 21, 2016
@bogdan-iancu
Copy link
Member

Hi @c-paradis , let me review it shortly and come back with feedback. Thanks for the contributions, Bogdan

@paradiscorentin
Copy link
Author

Hi @bogdan-iancu , i've added another option to the blacklist manager.
At the begining i didn't think about having hundreds or thousands entries in the database... So now i've added a search functionality to filter results and find the desired entries faster than before.

It works for the globalblacklist and the userblacklist as well

@bogdan-iancu
Copy link
Member

Hi @c-paradis , the patch looks good, but before merging, please place the Copyright and License text in all the new files . See the example from the existing file, simply copy and replace the Copyright line with your name/business/etc.

@bogdan-iancu
Copy link
Member

Thank you @c-paradis , I will shortly review.

@hogbinj hogbinj mentioned this pull request May 11, 2020
liviuchircu added a commit that referenced this pull request May 12, 2020
    * be compatible with any SQL mode.  This fixes:

	SELECT DISTINCT callid FROM sip_trace WHERE status='' AND
	    direction='in' ORDER BY id DESC;

	ERROR 3065 (HY000): Expression #1 of ORDER BY clause is not in
	    SELECT list, references column 'opensips.sip_trace.id' which
	    is not in SELECT list; this is incompatible with DISTINCT

    * be consistent across different backends (e.g. don't sort the
	results differently with MySQL vs. Postgres)

Fixes #83
liviuchircu added a commit that referenced this pull request May 12, 2020
    * be compatible with any SQL mode.  This fixes:

	SELECT DISTINCT callid FROM sip_trace WHERE status='' AND
	    direction='in' ORDER BY id DESC;

	ERROR 3065 (HY000): Expression #1 of ORDER BY clause is not in
	    SELECT list, references column 'opensips.sip_trace.id' which
	    is not in SELECT list; this is incompatible with DISTINCT

    * be consistent across different backends (e.g. don't sort the
	results differently with MySQL vs. Postgres)

Fixes #83

(cherry picked from commit e2c4246)
liviuchircu added a commit that referenced this pull request May 12, 2020
    * be compatible with any SQL mode.  This fixes:

	SELECT DISTINCT callid FROM sip_trace WHERE status='' AND
	    direction='in' ORDER BY id DESC;

	ERROR 3065 (HY000): Expression #1 of ORDER BY clause is not in
	    SELECT list, references column 'opensips.sip_trace.id' which
	    is not in SELECT list; this is incompatible with DISTINCT

    * be consistent across different backends (e.g. don't sort the
	results differently with MySQL vs. Postgres)

Fixes #83

(cherry picked from commit e2c4246)
liviuchircu added a commit that referenced this pull request Aug 24, 2020
liviuchircu added a commit that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants