Skip to content

First implementation of a jupyter nb based tutorial #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Nov 26, 2024
Merged

First implementation of a jupyter nb based tutorial #89

merged 52 commits into from
Nov 26, 2024

Conversation

LukasGold
Copy link
Contributor

Includes many changes to

  • osw.express, as those have been rigorously tested during the writing of the tutorial
  • osw.data.import_utility as the design had some flaws and was not as easy to use as it could have been
  • Documentation and doc strings

@LukasGold LukasGold added the enhancement New feature or request label Nov 6, 2024
@LukasGold LukasGold requested a review from SimonStier November 6, 2024 18:10
@LukasGold LukasGold self-assigned this Nov 6, 2024
@coveralls
Copy link

coveralls commented Nov 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12013579861

Details

  • 315 of 544 (57.9%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on enh-tutorial at 52.382%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/osw/controller/page_package.py 0 1 0.0%
src/osw/core.py 44 52 84.62%
src/osw/utils/wiki.py 19 34 55.88%
src/osw/model/static.py 77 96 80.21%
src/osw/wtsite.py 17 40 42.5%
src/osw/data/import_utility.py 12 43 27.91%
src/osw/express.py 23 58 39.66%
src/osw/utils/regex.py 101 147 68.71%
src/osw/params.py 0 51 0.0%
Totals Coverage Status
Change from base Build 11932637168: 52.4%
Covered Lines: 2833
Relevant Lines: 5075
💛 - Coveralls

simontaurus
simontaurus approved these changes Nov 8, 2024
View reviewed changes
@LukasGold LukasGold force-pushed the enh-tutorial branch 3 times, most recently from 67e1c79 to 96058b1 Compare November 18, 2024 22:08
@LukasGold
README update
6b021be
@LukasGold
import_with_fallback implented and some reformatting
c7d7c2a
@LukasGold
Doc string reformatting
81b3d66
@LukasGold
Reformatting
d7824fc
@LukasGold
Bug fixes and doc improvements to express.py
2cbac21
@LukasGold
Fix import_with_fallback()
df5cecd
@LukasGold
Improvements to usability and readability
22bbbaf
@LukasGold
Fix cases where the default_factory would not be present in the inher…
01f0b1d 
…ited model
@LukasGold
Fix: import_with_fallback() & Context Manager for osw_download_file()
c104e39
@LukasGold
Moving some functionality from functions in osw.utils.wiki to methods…
91bd5a2 
… of osw.model.static.OswBaseModel
@LukasGold
Making SearchParam available at WtSite.SearchParam
8539b95
@LukasGold
Making openpyxl a requirement for dataimport
b7222f3
@LukasGold
Improvements to import_utility.py - potentially breaking some functio…
5b5060c 
…ns, but most likely avoiding unwanted behavior
@LukasGold
Renaming of casted -> transformed
13acb67
@LukasGold
Fixing failing tests due to missing methods (on classes)
76bec5e
@LukasGold
Moving NoneType to a separate module
f63df22
@LukasGold
Validate attributes of OswBaseModel on assignment
df680e0
@LukasGold
Fixing validation errors, causing tests to fail
57957a1
@LukasGold
A collection of the param objects defined in the package
2967d43
@LukasGold
Introducing change id and StoreEntityResult
632a0a1
@LukasGold
Resolving circular import due to identical naming of osw.types
a42fddd
@LukasGold
Minor improvements to express functions
ee3def9
@LukasGold
Merge pull request #93 from OpenSemanticLab/feat-add-rdf-generation
665a189 
Feat: add rdf generation
# Conflicts:
#	src/osw/core.py
@LukasGold
Fixing: length of dictionary changed during iteration
c434777
@LukasGold
apply_overwrite_policy() should apply the removal of empty strings
f8959d2
@LukasGold
Fix: Validation error for Entity.label
0d9b87b 
list elements of type Label were being passed to Label(), causing validation errors
@LukasGold
First tutorial draft
d316236
@LukasGold
Continued content creation
db0d59e
@LukasGold
Content added and reworked
5846338
@LukasGold
Renaming of casted -> transformed
6606316
@LukasGold
README.md update to account for tutorial
557866f
@LukasGold
Rework tutorial notebook to incorporate tests and feedback, as well a…
0ae37ca 
…s latest fixes and improvements
@LukasGold
Draft of start_tutorial.ipynb - a notebook to start from zero
403adbc
@LukasGold
More content: semantic search
e093f41
@LukasGold LukasGold marked this pull request as ready for review November 22, 2024 15:29
simontaurus
simontaurus reviewed Nov 23, 2024
View reviewed changes
simontaurus
simontaurus requested changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@simontaurus simontaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@simontaurus simontaurus mentioned this pull request Nov 24, 2024
Merged
@simontaurus simontaurus merged commit 4b7d5dd into main Nov 26, 2024
9 checks passed
@LukasGold LukasGold deleted the enh-tutorial branch November 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simontaurus simontaurus simontaurus approved these changes

@SimonStier SimonStier Awaiting requested review from SimonStier

Assignees

@LukasGold LukasGold

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasGold @coveralls @simontaurus