Skip to content

fix: show invalid password error if pfx password is invalid #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: show invalid password error if pfx password is invalid #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/OpenSign/src/constant/Utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,9 +645,7 @@ export const signPdfFun = async (
status: "error",
message: "Currently encrypted pdf files are not supported."
};
} else if (
e.message === "PKCS#12 MAC could not be verified. Invalid password?"
) {
} else if (e?.message?.includes("password")) {
return { status: "error", message: "PFX file password is invalid." };
} else {
return { status: "error", message: "something went wrong." };
Expand Down
8 changes: 6 additions & 2 deletions apps/OpenSign/src/pages/PdfRequestFiles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,12 +1072,16 @@ function PdfRequestFiles(props) {
}
} else {
setIsUiLoading(false);
setIsAlert({ isShow: true, alertMessage: resSign.message });
setIsAlert({
title: "Error",
isShow: true,
alertMessage: resSign.message
});
}
} else {
setIsUiLoading(false);
setIsAlert({
header: t("error"),
title: "Error",
isShow: true,
alertMessage: t("pdf-uncompatible")
});
Expand Down
5 changes: 1 addition & 4 deletions apps/OpenSign/src/pages/SignyourselfPdf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,10 +687,7 @@ function SignYourSelf() {
});
} else {
console.log("err in signing", err.message);
if (
err.message ===
"PKCS#12 MAC could not be verified. Invalid password?"
) {
if (err?.message?.includes("password")) {
setIsAlert({
header: t("error"),
isShow: true,
Expand Down