remove checkbox from sign agreement screen #1858
Conversation
fix: remove agreement checkbox and remove agreement checkbox tour
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the agreement checkbox functionality and associated tour features from the document signing flow. The changes simplify the signing process by eliminating the requirement for users to check an agreement box before interacting with widgets.
- Removes checkbox and tour functionality for agreement confirmation
- Simplifies the agreement modal to only display terms with a direct agree button
- Adds improved error handling for login with specific error code 1001
- Updates translation files with new error message for domain restrictions
Reviewed Changes
Copilot reviewed 15 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/OpenSignServer/cloud/parsefunction/usersignup.js | Moves user creation inside try-catch block for better error handling |
| apps/OpenSign/src/pages/PdfRequestFiles.jsx | Removes agreement tour state and related functionality |
| apps/OpenSign/src/pages/Login.jsx | Adds specific error handling for code 1001 with domain restriction message |
| apps/OpenSign/src/components/pdf/RenderPdf.jsx | Removes agreement-related props from component |
| apps/OpenSign/src/components/pdf/Placeholder.jsx | Simplifies widget click handler by removing agreement check |
| apps/OpenSign/src/components/pdf/DefaultSignature.jsx | Removes agreement validation from signature confirmation |
| apps/OpenSign/src/components/pdf/AgreementSign.jsx | Removes checkbox UI and simplifies to direct agreement button |
| apps/OpenSign/src/components/pdf/AgreementContent.jsx | Removes tour-related prop handling |
| apps/OpenSign/src/components/Header.jsx | Adds admin role check logic |
| Translation files | Adds "action-prohibited" message in multiple languages |
| const defaultSignImg = useSelector((state) => state.widget.defaultSignImg); | ||
| const myInitial = useSelector((state) => state.widget.myInitial) | ||
| const defaultSignImg = useSelector((state) => state.widget.defaultSignImg); | ||
| const myInitial = useSelector((state) => state.widget.myInitial); |
There was a problem hiding this comment.
Missing semicolon in the variable declaration on the previous line. The removed line had a semicolon, but the replacement line is missing one.
Copilot uses AI. Check for mistakes.
| } | ||
| }; | ||
| //function to get first widget and page number to assign currect signer and tour message | ||
| //function to get first widget id and page number to assign correct signer and show tour message |
There was a problem hiding this comment.
Typo in the comment: 'currect' should be 'correct'.
Copilot uses AI. Check for mistakes.
| props.setIsAgreeTour(true); | ||
| } | ||
| props.setIsAgree(true); | ||
| props.showFirstWidget() |
There was a problem hiding this comment.
Missing semicolon at the end of the function call.
| props.showFirstWidget() | |
| props.showFirstWidget(); |
Copilot uses AI. Check for mistakes.
prafull-opensignlabs
changed the title
prafull-opensignlabs
changed the title
fix: remove agreement checkbox and remove agreement checkbox tour