v2.29.0 #1966
v2.29.0 #1966
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces version v2.29.0 with significant improvements to file handling, UI enhancements, and localization updates. The release focuses on increasing file size limits, improving the file upload system, and enhancing the user experience with better date widgets and modal components.
- Increased file size limits from 30MB to 100MB across server configurations
- Implemented new file upload utility with direct API calls to improve reliability
- Enhanced date widget functionality with better validation and user controls
Reviewed Changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/OpenSignServer/utils/fileUtils.js | Added new parseUploadFile utility function for direct file uploads |
| apps/OpenSignServer/package.json | Updated AWS SDK and Sharp package versions |
| apps/OpenSignServer/index.js | Increased maxUploadSize and Express body limits to 100MB |
| apps/OpenSignServer/cloud/parsefunction/saveFile.js | Refactored to use new parseUploadFile function instead of Parse.File |
| apps/OpenSign/src/constant/const.js | Updated maxFileSize constant from 10MB to 80MB |
| apps/OpenSign/src/components/pdf/Placeholder.jsx | Enhanced date widget with improved validation and UI controls |
| Multiple translation files | Added new translation keys for enhanced feedback and UI messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| mimeType = 'application/pdf'; | ||
| const flatPdf = await flattenPdf(fileBase64); | ||
| file = [...flatPdf]; | ||
| // file = [...flatPdf]; |
There was a problem hiding this comment.
The commented out code should be removed instead of being left in place. If this change is intentional and the spread operator is no longer needed, the old code should be deleted to improve code cleanliness.
| // file = [...flatPdf]; |
Copilot uses AI. Check for mistakes.
| const [isNextStep, setIsNextStep] = useState({}); | ||
| const [isBulkSend, setIsBulkSend] = useState({}); | ||
| const [templateDeatils, setTemplateDetails] = useState({}); | ||
| const [templateDetails, setTemplateDetails] = useState({}); |
There was a problem hiding this comment.
Variable name has been corrected from 'templateDeatils' to 'templateDetails' - this is a good fix for the typo.
Copilot uses AI. Check for mistakes.
| currWidgetsDetails?.options?.validation?.format | ||
| ) | ||
| : new Date() | ||
| : "" |
There was a problem hiding this comment.
The default value for startDate has been changed from 'new Date()' to an empty string. This could cause issues with the DatePicker component which expects a Date object. Consider using 'null' instead of an empty string for better type safety.
| : "" | |
| : null |
Copilot uses AI. Check for mistakes.
| }} | ||
| className={`${isReadOnly ? `select-none` : ``} ${selectWidgetCls} overflow-hidden`} | ||
| disabled={isReadOnly} | ||
| className={`${isReadOnly ? `select-none opacity-25` : ``} ${selectWidgetCls} overflow-hidden`} |
There was a problem hiding this comment.
The disabled prop has been removed but the visual styling with opacity-25 has been added. Consider keeping the disabled prop for proper accessibility and form behavior, in addition to the visual styling.
Copilot uses AI. Check for mistakes.
| if (formdata?.isReadOnly && !selectDate.date && !isToday) { | ||
| alert(t("read-only-date-error")); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Using alert() for user feedback is not ideal for modern web applications. Consider using a proper notification system or modal dialog for better user experience and consistency with the rest of the application.
Copilot uses AI. Check for mistakes.
No description provided.