Skip to content

fix: onclick upgrade to customize email button redirect new window of subscription page #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: onclick upgrade to customize email button redirect new window of subscription page #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/OpenSign/src/pages/PlaceHolderSign.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,6 @@ function PlaceHolderSign() {
updateExpiryDate.setDate(updateExpiryDate.getDate() + addExtraDays);
//filter label widgets after add label widgets data on pdf
const filterPrefill = signerPos.filter((data) => data.Role !== "prefill");

try {
if (updateExpiryDate) {
data = {
Expand Down Expand Up @@ -1769,7 +1768,10 @@ function PlaceHolderSign() {
)}

{!isSubscribe && isEnableSubscription && (
<Upgrade message="Upgrade to customize Email" />
<Upgrade
message="Upgrade to customize Email"
newWindow={true}
/>
)}
</div>
</>
Expand Down
12 changes: 10 additions & 2 deletions apps/OpenSign/src/primitives/Upgrade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
import React from "react";
import { useNavigate } from "react-router-dom";
import { openInNewTab } from "../constant/Utils";

function Upgrade({ message }) {
function Upgrade({ message, newWindow }) {
const navigation = useNavigate();

return (
<sup>
<span
onClick={() => navigation("/subscription")}
onClick={() => {
if (newWindow) {
const url = window.location.origin + "/subscription";
openInNewTab(url);
} else {
navigation("/subscription");
}
}}
className="text-blue-800 text-sm cursor-pointer underline"
>
{message ? message : "Upgrade now"}
Expand Down