Skip to content

Fix image reference for StVO 222 and 222-10 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarcelOliver
Copy link
Contributor

Documentation bug probably due to 2017 renumbering of signs

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@pmai pmai self-requested a review April 28, 2020 09:38
@pmai pmai self-assigned this Apr 28, 2020
@pmai pmai added Bug Problems in the build system, build scripts, etc or faults in the interface. Documentation Everything which impacts the quality of the documentation and guidelines. labels Apr 28, 2020
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agrees with BASt 2017.

@jdsika
Copy link
Contributor

jdsika commented Apr 28, 2020

@pmai we seem to have issues with the build pipeline and forks

@pmai
Copy link
Contributor

pmai commented Apr 29, 2020

@pmai we seem to have issues with the build pipeline and forks

I think the whole travis CI pipeline is broken, i.e. notifications are going out and are acknowledged with 204 code by travis, but nothing then happens; I've tried to re-confirm the webhooks and nothing changed; don't know how to reactivate the travis CI side of things...

But probably switching from legacy to new app approach would maybe help...

@pmai pmai force-pushed the fix/stvo222-image-references branch from 299d2c8 to b76bc1a Compare April 29, 2020 10:26
@pmai
Copy link
Contributor

pmai commented Apr 29, 2020

I've migrated the OpenSimulationInterface org to the new unified Travis CI App, i.e. every build status is now under travis-ci.com, not travis-ci.org, and reconnected everything for OSI, so this now seems to work half-way sanely. Probably needs some changes to build buttons, etc., will handle that later.

This is to make everything work for now, ASAM migration might move to different build infrastructure later on.

@pmai pmai merged commit a097300 into OpenSimulationInterface:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. Documentation Everything which impacts the quality of the documentation and guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants