Clarification static dynamic #768
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 402b2af.
- Static - Dynamic - Depending to documentation. Signed-off-by: Thomas Hempen <thomas.hempen@thi.de>
thempen
added
the
Documentation
- removed comments on traffic command - this is basically a request-reply message / event - changed some documentation on traffic signs Signed-off-by: Thomas Hempen <thomas.hempen@thi.de>
- changed some documentation on traffic signs Signed-off-by: Thomas Hempen <thomas.hempen@thi.de>
Added changeability information. Signed-off-by: Thomas Hempen <thomas.hempen@thi.de>
The messages are by default dynamic. Just the interface version is static throughout a simulation. Signed-off-by: Thomas Hempen <thomas.hempen@thi.de>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS WORK IN PROGRESS AND NOT MEANT TO BE NEARLY READY FOR MERGE.
The PR should improve the information within the documentation on how often changes shall be expected.
For general discussion points and Q&A, there is an Issue #770 .
Some questions to ask:
What is this change?
A change in the inline documentation changable data.
What does it fix?
In many cases, it is unclear if data changes, or not. E.g., will the road geometry change? In the reality - probably not. Eithin the data - it could be in certain cases. This PR should give more information about where to look at and which data should be considered changeable.
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
No breaking changes.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: