Fix #118: Added contest page functionality #129

abarya · 2017-10-06T17:48:02Z

I have added the functionality to view all the contests at one page. Also added a contest form using which any user can add information regarding the upcoming contests.

It looks likes this:

And the form:

houndci-bot · 2017-10-06T17:48:12Z

oshc/main/views.py

+
+    contest.save()
+
+    return HttpResponseRedirect("/contests/")


no newline at end of file

houndci-bot · 2017-10-06T17:48:12Z

oshc/main/views.py

+    end_date = request.POST.get("end_date", "null")
+    contest.description = request.POST.get("desc", "null")
+
+    contest.end_date=datetime.strptime(end_date,'%Y-%m-%d').date()


missing whitespace around operator
missing whitespace after ','

houndci-bot · 2017-10-06T17:48:12Z

oshc/main/views.py

+    contest = Contest()
+    contest.name = request.POST.get("name", "null")
+    contest.link = request.POST.get("link", "null")
+    start_date = request.POST.get("start_date","null")


missing whitespace after ','

houndci-bot · 2017-10-06T17:48:12Z

oshc/main/views.py

+
+
+def contest_new(request):
+    return render(request,'contest_edit.html')


missing whitespace after ','

houndci-bot · 2017-10-06T17:48:12Z

oshc/main/views.py

+
+def contests(request):
+    contest_list = Contest.objects.all()
+    return render(request, 'contests.html', context={'contest_list':contest_list})


missing whitespace after ':'
line too long (82 > 79 characters)

houndci-bot · 2017-10-06T17:48:12Z

oshc/main/models.py

+class Contest(models.Model):
+    name = models.CharField(max_length=128, help_text="Contest name")
+    link = models.URLField(help_text="URL of the contest's website")
+    description = models.TextField(max_length=512, help_text="Contest details",null=True)


missing whitespace after ','
line too long (89 > 79 characters)

houndci-bot · 2017-10-06T17:48:12Z

oshc/main/models.py

@@ -15,3 +15,13 @@ class chatSession(models.Model):

    def __str__(self):
        return self.title
+
+class Contest(models.Model):


expected 2 blank lines, found 1

abarya · 2017-10-06T17:48:38Z

Hi @vaibhavsingh97 @tapasweni-pathak
Please review this.

vaibhavsingh97 · 2017-10-06T18:17:58Z

@abhishekarya286 Wow!! I am impressed 👏 👏 You have done an awesome job 🎉 🎉 . Can you please fix the suggestions of Hounds CI and also can you please add link in the form. Also, For the visual enhancement can we have something like this. Keep contributing 😄

abarya · 2017-10-06T19:48:17Z

Hi @vaibhavsingh97,
Thanks for reviewing. I added bootstrap to the contest page and it looks fine to me now.
Also, I don't know why The Travis CI build failed error. Please help me with this.

vaibhavsingh97 · 2017-10-07T13:04:14Z

@abhishekarya286 This error came because you havn't pushed migration file. Please push migration file than this error will be resolved

houndci-bot · 2017-10-07T14:25:43Z

oshc/main/migrations/0002_contests.py

+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),
+                ('link', models.URLField(help_text="URL of the contest's website")),
+                ('description', models.TextField(help_text='Contest details', max_length=512)),


line too long (95 > 79 characters)

houndci-bot · 2017-10-07T14:25:43Z

oshc/main/migrations/0002_contests.py

+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),
+                ('link', models.URLField(help_text="URL of the contest's website")),


line too long (84 > 79 characters)

houndci-bot · 2017-10-07T14:25:43Z

oshc/main/migrations/0002_contests.py

+            name='contests',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),


line too long (85 > 79 characters)

houndci-bot · 2017-10-07T14:25:43Z

oshc/main/migrations/0002_contests.py

+        migrations.CreateModel(
+            name='contests',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),


line too long (114 > 79 characters)

houndci-bot · 2017-10-07T14:29:45Z

oshc/main/migrations/0004_auto_20171005_1829.py

+        migrations.AlterField(
+            model_name='contest',
+            name='description',
+            field=models.TextField(help_text='Contest details', max_length=512, null=True),


line too long (91 > 79 characters)

houndci-bot · 2017-10-07T14:29:45Z

oshc/main/migrations/0004_auto_20171005_1829.py

+        migrations.AlterField(
+            model_name='contest',
+            name='description',
+            field=models.TextField(help_text='Contest details', max_length=512, null=True),


line too long (91 > 79 characters)

coveralls · 2017-10-07T14:30:35Z

Coverage decreased (-9.6%) to 80.612% when pulling 914fee7 on abhishekarya286:contestpage into ce318c9 on OpenSourceHelpCommunity:develop.

houndci-bot · 2017-10-07T14:42:11Z

oshc/main/migrations/0002_contests.py

+                ('link',
+                    models.URLField(help_text="URL of the contest's website")),
+                ('description', models.TextField(help_text='Contest details',
+                    max_length=512)),


continuation line under-indented for visual indent

houndci-bot · 2017-10-07T14:42:11Z

oshc/main/migrations/0002_contests.py

+                ('id', models.AutoField(auto_created=True,
+                    primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name',
+                    max_length=128)),


continuation line under-indented for visual indent

houndci-bot · 2017-10-07T14:42:11Z

oshc/main/migrations/0002_contests.py

+            name='contests',
+            fields=[
+                ('id', models.AutoField(auto_created=True,
+                    primary_key=True, serialize=False, verbose_name='ID')),


continuation line under-indented for visual indent

coveralls · 2017-10-07T14:42:53Z

Coverage decreased (-9.6%) to 80.612% when pulling aa64c74 on abhishekarya286:contestpage into ce318c9 on OpenSourceHelpCommunity:develop.

vaibhavsingh97 · 2017-10-07T14:46:14Z

@abhishekarya286 One trick : Use autopep8 tool 😄
Also, It's best that if you have changed any thing so before migrating delete old migration file. Can you please clean unnecessary migration files 😅 .
Sorry, If you are facing too much difficulty. You can DM me anytime, I am happy to help you 😄

coveralls · 2017-10-07T14:54:35Z

Coverage decreased (-9.6%) to 80.612% when pulling 2dc1314 on abhishekarya286:contestpage into ce318c9 on OpenSourceHelpCommunity:develop.

houndci-bot · 2017-10-07T16:43:26Z

oshc/main/migrations/0001_initial.py

+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),
+                ('link', models.URLField(help_text="URL of the contest's website")),
+                ('description', models.TextField(help_text='Contest details', max_length=512, null=True)),


line too long (106 > 79 characters)

houndci-bot · 2017-10-07T16:43:26Z

oshc/main/migrations/0001_initial.py

+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),
+                ('link', models.URLField(help_text="URL of the contest's website")),


line too long (84 > 79 characters)

houndci-bot · 2017-10-07T16:43:26Z

oshc/main/migrations/0001_initial.py

+            name='Contest',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),


line too long (85 > 79 characters)

houndci-bot · 2017-10-07T16:43:26Z

oshc/main/migrations/0001_initial.py

+        migrations.CreateModel(
+            name='Contest',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),


line too long (114 > 79 characters)

houndci-bot · 2017-10-07T16:43:26Z

oshc/main/migrations/0001_initial.py

+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),
+                ('link', models.URLField(help_text="URL of the contest's website")),
+                ('description', models.TextField(help_text='Contest details', max_length=512, null=True)),


line too long (106 > 79 characters)

houndci-bot · 2017-10-07T16:43:26Z

oshc/main/migrations/0001_initial.py

+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),
+                ('link', models.URLField(help_text="URL of the contest's website")),


line too long (84 > 79 characters)

houndci-bot · 2017-10-07T16:43:26Z

oshc/main/migrations/0001_initial.py

+            name='Contest',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),


line too long (85 > 79 characters)

houndci-bot · 2017-10-07T16:43:26Z

oshc/main/migrations/0001_initial.py

+        migrations.CreateModel(
+            name='Contest',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),


line too long (114 > 79 characters)

coveralls · 2017-10-07T16:44:24Z

Coverage decreased (-14.6%) to 75.641% when pulling b6d62e0 on abhishekarya286:contestpage into ce318c9 on OpenSourceHelpCommunity:develop.

houndci-bot · 2017-10-07T16:53:53Z

oshc/main/migrations/0001_initial.py

+                ('id', models.AutoField(auto_created=True,
+                                        primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),
+                ('link', models.URLField(help_text="URL of the contest's website")),


line too long (84 > 79 characters)

houndci-bot · 2017-10-07T16:53:53Z

oshc/main/migrations/0001_initial.py

+            fields=[
+                ('id', models.AutoField(auto_created=True,
+                                        primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', max_length=128)),


line too long (85 > 79 characters)

houndci-bot · 2017-10-07T16:53:53Z

oshc/main/migrations/0001_initial.py

+            name='Contest',
+            fields=[
+                ('id', models.AutoField(auto_created=True,
+                                        primary_key=True, serialize=False, verbose_name='ID')),


line too long (95 > 79 characters)

houndci-bot · 2017-10-07T16:53:53Z

oshc/main/migrations/0001_initial.py

@@ -16,14 +16,32 @@ class Migration(migrations.Migration):
        migrations.CreateModel(
            name='chatSession',
            fields=[
-                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('id', models.AutoField(auto_created=True,
+                                        primary_key=True, serialize=False, verbose_name='ID')),


line too long (95 > 79 characters)

coveralls · 2017-10-07T16:54:42Z

Coverage decreased (-14.6%) to 75.641% when pulling 2f68269 on abhishekarya286:contestpage into ce318c9 on OpenSourceHelpCommunity:develop.

houndci-bot · 2017-10-07T17:01:07Z

oshc/main/migrations/0001_initial.py

+                ('name', models.CharField(help_text='Contest name', 
+                max_length=128)),
+                ('link', 
+                models.URLField(help_text="URL of the contest's website")),


continuation line under-indented for visual indent

houndci-bot · 2017-10-07T17:01:08Z

oshc/main/migrations/0001_initial.py

+                primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', 
+                max_length=128)),
+                ('link', 


trailing whitespace

houndci-bot · 2017-10-07T17:01:08Z

oshc/main/migrations/0001_initial.py

+                ('id', models.AutoField(auto_created=True,
+                primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', 
+                max_length=128)),


continuation line under-indented for visual indent

houndci-bot · 2017-10-07T17:01:08Z

oshc/main/migrations/0001_initial.py

+            fields=[
+                ('id', models.AutoField(auto_created=True,
+                primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(help_text='Contest name', 


trailing whitespace

houndci-bot · 2017-10-07T17:01:08Z

oshc/main/migrations/0001_initial.py

+            name='Contest',
+            fields=[
+                ('id', models.AutoField(auto_created=True,
+                primary_key=True, serialize=False, verbose_name='ID')),


continuation line under-indented for visual indent

houndci-bot · 2017-10-07T17:01:08Z

oshc/main/migrations/0001_initial.py

@@ -16,14 +16,34 @@ class Migration(migrations.Migration):
        migrations.CreateModel(
            name='chatSession',
            fields=[
-                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('id', models.AutoField(auto_created=True,
+                primary_key=True, serialize=False, verbose_name='ID')),


continuation line under-indented for visual indent

coveralls · 2017-10-07T17:02:02Z

Coverage decreased (-14.6%) to 75.641% when pulling 0b199f6 on abhishekarya286:contestpage into ce318c9 on OpenSourceHelpCommunity:develop.

coveralls · 2017-10-07T17:10:11Z

Coverage decreased (-14.6%) to 75.641% when pulling d039763 on abhishekarya286:contestpage into ce318c9 on OpenSourceHelpCommunity:develop.

coveralls · 2017-10-07T17:33:35Z

Coverage decreased (-8.9%) to 69.565% when pulling 0e753ff on abhishekarya286:contestpage into e88dada on OpenSourceHelpCommunity:develop.

abarya · 2017-10-07T17:37:12Z

@vaibhavsingh97, thanks for your help. But still, I'm having issues with hound CI. I've tried using autopep8 but it also didn't help much.
Can you suggest something?

vaibhavsingh97 · 2017-10-07T17:50:38Z

Hey!! @abhishekarya286 Can we talk on slack. Request your invite here 😄

coveralls · 2017-10-07T18:40:57Z

Coverage decreased (-8.9%) to 69.565% when pulling 303513b on abhishekarya286:contestpage into e88dada on OpenSourceHelpCommunity:develop.

houndci-bot · 2017-10-07T18:57:12Z

oshc/main/views.py


-from main.models import chatSession
+from django.template import RequestContext


redefinition of unused 'RequestContext' from line 10

houndci-bot · 2017-10-07T18:57:12Z

oshc/main/views.py


 from django.shortcuts import render_to_response

 from django.template import RequestContext
+from django.shortcuts import render_to_response


redefinition of unused 'render_to_response' from line 8

coveralls · 2017-10-07T18:57:51Z

Coverage decreased (-8.2%) to 70.213% when pulling 2b8fe3f on abhishekarya286:contestpage into e88dada on OpenSourceHelpCommunity:develop.

coveralls · 2017-10-07T19:07:40Z

Coverage decreased (-8.9%) to 69.565% when pulling 89ca22e on abhishekarya286:contestpage into e88dada on OpenSourceHelpCommunity:develop.

abarya · 2017-10-07T19:09:21Z

@vaibhavsingh97. Please review this PR.

vaibhavsingh97

Hi!! @abhishekarya286 can you convert current UI something like this and also make sure no content should come below icon (Refer screenshot)

We can use AdminDateWidget to get Django admin date, this will make things simple. As of now if enter wrong fomat of date result in 500 error (this error will be reduced). After merge I will open new issue for right feedback after user enter wrong data in the fireld 😄

vaibhavsingh97 · 2017-10-07T20:32:31Z

oshc/main/templates/contests.html

+                <div class="panel panel-default">
+                    <div class="panel-heading"><a href="{{contest.link}}">{{contest.name}}</a></div>
+                    <div class="panel-body">
+                        <strong>Start Date:</strong> {{contest.start_date}}<br>


don't use <br> instead make css class and use that.

Hi @vaibhavsingh97,
you said, "also make sure no content should come below icon (Refer screenshot)"
below which icon??

vaibhavsingh97 · 2017-10-07T20:33:27Z

oshc/main/views.py

@@ -1,11 +1,14 @@
 from django.shortcuts import render
+from django.http import HttpResponseRedirect
+


Remove blank lines

vaibhavsingh97 · 2017-10-07T20:33:34Z

oshc/main/views.py

+from django.http import HttpResponseRedirect
+
+from main.models import chatSession, Contest
+


vaibhavsingh97 · 2017-10-07T20:33:59Z

oshc/main/views.py

+
+
+def add_contest(request):
+


vaibhavsingh97 · 2017-10-07T20:34:07Z

oshc/main/views.py

+    start_date = request.POST.get("start_date", "null")
+    end_date = request.POST.get("end_date", "null")
+    contest.description = request.POST.get("desc", "null")
+


vaibhavsingh97 · 2017-10-07T20:34:26Z

oshc/main/views.py

+
+    contest.end_date = datetime.strptime(end_date, '%Y-%m-%d').date()
+    contest.start_date = datetime.strptime(start_date, '%Y-%m-%d').date()
+


coveralls · 2017-10-08T11:33:50Z

Coverage decreased (-8.9%) to 69.565% when pulling a1092ca on abhishekarya286:contestpage into e88dada on OpenSourceHelpCommunity:develop.

abarya · 2017-10-08T11:36:05Z

@vaibhavsingh97,
I was unable to add a calendar using AdminDateWidget(). Other than this, please review.

tapaswenipathak

Thanks for the work! I have received one email per houndci comment and your commit.:smile:, thanks for patiently fixing all the issues.

We need one more field in the table not visible on the UI which will say approved by the admin. Admin will login through django admin console and the manually say 'X' in the field for now, later we will allow admin to see submitted contest on their console. Submission of contests by the user needs to be reviewed by the admin first. After clicking on submit we need to "contest submitted for review".

tapaswenipathak · 2017-10-08T11:47:13Z

oshc/main/migrations/0001_initial.py

+                ('id', models.AutoField(auto_created=True,
+                                        primary_key=True,
+                                        serialize=False, verbose_name='ID')),
+                ('title', models.CharField(help_text='Session title',


@abhishekarya286 is this pep8?

Nope. I had to manually do it like that so that hound ci error doesn't come. With hound ci, you'll get something like:
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),

Thanks for reviewing @tapasweni-pathak,
So what I'm trying to do now is adding up a boolean field in the contest model which will be having a default value 0. So, when the user will submit the contest, the admin can then review it and if he/she finds that this contest can be put up on the website then he/she can change the boolean field to 1 and the contest will be displayed on the website. Is it okay?

Yeah, cool. Please go ahead.

coveralls · 2017-10-08T14:09:44Z

Coverage decreased (-9.0%) to 69.474% when pulling e704eba on abhishekarya286:contestpage into e88dada on OpenSourceHelpCommunity:develop.

abarya · 2017-10-08T14:11:52Z

Hi, @tapasweni-pathak,
I have added a field for approval of submissions which will be visible in the console. Also, I have added a thank you page which will be shown after submission. Kindly review.

abarya · 2017-10-09T16:41:08Z

@tapasweni-pathak, Any updates??

tapaswenipathak

@abhishekarya286 Thanks for the work!

You know I will be raising more issues after merging this, for checks, replacing form with crispy-forms but this is a great base to do the changes on! Merging this. 🚀

abarya · 2017-10-14T12:32:30Z

@tapasweni-pathak, thanks for merging.

houndci-bot reviewed Oct 6, 2017

View reviewed changes

abarya added 2 commits October 7, 2017 04:43

Fix OpenSourceHelpCommunity#118: Added contest page functionality

990e15e

removed linting errors

7e205f9

houndci-bot reviewed Oct 7, 2017

View reviewed changes

Resolved Travis CI and Hound CI errors

5fab971

abarya force-pushed the contestpage branch from 303513b to 5fab971 Compare October 7, 2017 18:54

Merge branch 'develop' into contestpage

2b8fe3f

houndci-bot reviewed Oct 7, 2017

View reviewed changes

minor nits

89ca22e

vaibhavsingh97 suggested changes Oct 7, 2017

View reviewed changes

vaibhavsingh97 requested review from tapaswenipathak and nikhita October 7, 2017 20:36

UI changed

a1092ca

tapaswenipathak requested changes Oct 8, 2017

View reviewed changes

Added thanking page and review option

e704eba

vaibhavsingh97 requested a review from tapaswenipathak October 12, 2017 00:55

tapaswenipathak approved these changes Oct 14, 2017

View reviewed changes

tapaswenipathak merged commit bad80c8 into OpenSourceHelpCommunity:develop Oct 14, 2017



		def contest_new(request):
		return render(request,'contest_edit.html')


		from main.models import chatSession
		from django.template import RequestContext

		@@ -1,11 +1,14 @@
		from django.shortcuts import render
		from django.http import HttpResponseRedirect

		from django.http import HttpResponseRedirect

		from main.models import chatSession, Contest


		contest.end_date = datetime.strptime(end_date, '%Y-%m-%d').date()
		contest.start_date = datetime.strptime(start_date, '%Y-%m-%d').date()

Fix #118: Added contest page functionality #129

Fix #118: Added contest page functionality #129

Uh oh!

Conversation

abarya commented Oct 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abarya commented Oct 6, 2017

Uh oh!

vaibhavsingh97 commented Oct 6, 2017

Uh oh!

abarya commented Oct 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vaibhavsingh97 commented Oct 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 7, 2017

Uh oh!

vaibhavsingh97 commented Oct 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abarya commented Oct 6, 2017 •

edited

Loading

vaibhavsingh97 commented Oct 7, 2017 •

edited

Loading