-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make git repository setup optional #864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should happen when using mongo, as for the contrib instance
martinratinaud
force-pushed
the
conditional_git_repo_ops
branch
from
May 19, 2022 05:14
7f14d78
to
8a19fb1
Compare
Tested on vagrant
|
Ndpnt
reviewed
May 23, 2022
snapshots_branch: master | ||
versions_repository: git@github.com:OpenTermsArchive/contrib-versions.git | ||
versions_branch: main | ||
snapshots_repository: git@github.com:OpenTermsArchive/sandbox-snapshots.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to do this for a long time, thank you! 👍
Ndpnt
approved these changes
May 23, 2022
Tested locally. It works.
It's due to the fact that the engine try to push on a non existent remote. I will open an issue for this. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As use can choose mongo OR git as a database system, there may be no need to create nor define repositories url.
Let's make it optional