Prevent numbers from being formatted in scientific notation in forms #3208
Conversation
|
The tag is working well for the built in fields but I added a custom Looks good in the form
Notated after save
|
maurizi
force-pushed
the
no-scientific-notation
branch
from
20f5930 to
537c391
Compare
Fixed in (rebased) commit 537c391. I also fixed formatting for numbers in the edits sidebar, and made sure we don't show trailing zeros |
opentreemap/treemap/util.py
Outdated
| def num_format(num): | ||
| if isinstance(num, float): | ||
| # Allow for up to 10 digits of precision, but strip trailing 0s | ||
| return '{0:.10f}'.format(num).rstrip('0') |
There was a problem hiding this comment.
For any "whole number" value like 123.0 this rstrip is leaving a trailing .
opentreemap/treemap/util.py
Outdated
| def num_format(num): | ||
| if isinstance(num, float): | ||
| # Allow for up to 10 digits of precision, but strip trailing '0' or '.' | ||
| return '{0:.10f}'.format(num).rstrip('0.') |
There was a problem hiding this comment.
It looks like this rstrip call will remove too many characters when the whole number portion of the decimal ends in 0.
In [1]: '120.0'.rstrip('0.')
Out[1]: '12'Chaining rstrips looks like it will give us what we are looking for
In [2]: '120.0'.rstrip('0').rstrip('.')
Out[2]: '120'
In [3]: '120.01'.rstrip('0').rstrip('.')
Out[3]: '120.01'
In [4]: '120.010'.rstrip('0').rstrip('.')
Out[4]: '120.01'There was a problem hiding this comment.
Sigh... sorry for all the back and forth. Fixed in 149dfea
maurizi
force-pushed
the
no-scientific-notation
branch
from
7bdee5f to
149dfea
Compare
3 participants
Connects to #2733