-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod Feature: Remove content from "Flagged Items" #642
Comments
"Pardoning" seems like an interesting concept. :) |
Just realized this is a dupe of #134 although it's better worded here! :) Closing the other issue. |
I created a nearly exact duplicate of another issue I created almost exactly a year later... I think I might be getting old... |
Naw ... just getting wiser. :) Questions:
|
|
|
Okay, here is the problem. I never remember anyone with a role of admin or above being able to flag anything. In fact, I made a conscious decision not to allow this: see my code in a very early version of libs/flag.js (the module that controls the rules behind flagging). I did some research and found out that apparently @Zren took it upon himself to silently remove this logic, even though why it's there is clearly commented. It was a long time ago, and I guess I just never realized I could flag things. I would like this reversed. Admins+ are not supposed to be part of the moderation system. They just take action when needed. My intended design has a clear separation between admins+ and all other users. |
Well I can restore that part but I would still like to be able to long term track a user... but I can do that with my Thanks for the insight and clarification. |
I think it's fine for you to have a mod account to flag things you want to
|
Well I still have that recommendation for a Moderator if he accepts but the Moderation tools have to be complete otherwise anyone won't bother... that's why I assigned myself to these issues... so hopefully we can find the right balance and understanding. I've been a sysop for decades on many other protocols so this isn't much extra work for me having dual roles... but not forever hopefully... plus it helps me understand what the goal is/was. :) |
* Some STYLEGUIDE.md conformance in this function * Restored the comments too **NOTES** Confirmed that User, Author and Moderator can still flag in the UI... Admin can't as per role logic at all methods... reset dev DB flags and pro DB flags to reflect this reversion See also: * OpenUserJS@df552c7#diff-f968c831502e727188f4ce4cf56f755fL11 * OpenUserJS#642 (comment) Applies to OpenUserJS#642
Okay so followup question for 1) ...
|
No. A moderator cannot pardon content flagged by another moderator. In a
|
Re:
In order to pardon a moderator must know the reason why a script is flagged. We can make the reporter invisible but without this info they can't pardon based off guessing why it was flagged. |
* Moderators can now see the reason why something is flagged. This is absolutely necessary to evaluate if a pardon occurs. Moderators may currently additionally flag with their requested intentions/summary. This has been idle on response for several years and really has to be implemented this way. * Moderators will only see Rank so that there isn't a flame war since @sizzlemctwizzle defined it as ~"dime a dozen". * Moved flagger *(renamed to match)* to mod panel and put a danger class on it for those that can remove to prevent accidental removal *(hasn't happened yet but good idea)* * Some twiddling with class usage in *bootstrap* UI Applies to OpenUserJS#642 Note(s): * This version of mustache generates a lot of extra UI code due to `{{#isAdmin}}` not being in scope in certain circumstances.
* Moderators can now see the reason why something is flagged. This is absolutely necessary to evaluate if a pardon occurs. Moderators may currently additionally flag with their requested intentions/summary. This has been idle on response for several years and really has to be implemented this way. * Moderators will only see Rank so that there isn't a flame war since @sizzlemctwizzle defined it as ~"dime a dozen". * Moved flagger *(renamed to match)* to mod panel and put a danger class on it for those that can remove to prevent accidental removal *(hasn't happened yet but good idea)* * Some twiddling with class usage in *bootstrap* UI Applies to #642 Note(s): * This version of mustache generates a lot of extra UI code due to `{{#isAdmin}}` not being in scope in certain circumstances. Auto-merge
* Ref: Post OpenUserJS#642 (comment) * Bloat up *mu2* *(mustache)* with some deep conditionals instead to achieve this. Not that this is a new thing. * Also expose "Yes" to Moderators for ambiguity. Parallel to actual flag list ambiguity. This can change if discussed with establishing owner but content will be semi-blocked when implemented *(fully on homepages and partial currently on flagged moderation lists)*. Post OpenUserJS#1943 OpenUserJS#1942 OpenUserJS#785 NOTE: * If you don't "trust the admin" going up the hierarchy can block the content but need to know counts at least for manual validation and actions upon moderation.
* Ref: Post #642 (comment) * Bloat up *mu2* *(mustache)* with some deep conditionals instead to achieve this. Not that this is a new thing. * Also expose "Yes" to Moderators for ambiguity. Parallel to actual flag list ambiguity. This can change if discussed with establishing owner but content will be semi-blocked when implemented *(fully on homepages and partial currently on flagged moderation lists)*. Post #1943 #1942 #785 NOTE: * If you don't "trust the admin" going up the hierarchy can block the content but need to know counts at least for manual validation and actions upon moderation. Auto-merge
The flag count would not be reset but instead
content.flagged = false;
(pardon). If the content gets flagged again, it would once again show up for review and possible removal/pardoning.The text was updated successfully, but these errors were encountered: