Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move around flagging a bit. #1818

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Move around flagging a bit. #1818

merged 1 commit into from
Jun 3, 2021

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 3, 2021

  • Moderators can now see the reason why something is flagged. This is absolutely necessary to evaluate if a pardon occurs. Moderators may currently additionally flag with their requested intentions/summary. This has been idle on response for several years and really has to be implemented this way.
  • Moderators will only see Rank so that there isn't a flame war since @sizzlemctwizzle defined it as ~"dime a dozen".
  • Moved flagger (renamed to match) to mod panel and put a danger class on it for those that can remove to prevent accidental removal (hasn't happened yet but good idea)
  • Some twiddling with class usage in bootstrap UI

Applies to #642

Note(s):

  • This version of mustache generates a lot of extra UI code due to {{#isAdmin}} not being in scope in certain circumstances.

@Martii
Move around flagging a bit.
cf20fa6 
* Moderators can now see the reason why something is flagged. This is absolutely necessary to evaluate if a pardon occurs. Moderators may currently additionally flag with their requested intentions/summary. This has been idle on response for several years and really has to be implemented this way.
* Moderators will only see Rank so that there isn't a flame war since @sizzlemctwizzle defined it as ~"dime a dozen".
* Moved flagger *(renamed to match)* to mod panel and put a danger class on it for those that can remove to prevent accidental removal *(hasn't happened yet but good idea)*
* Some twiddling with class usage in *bootstrap* UI

Applies to OpenUserJS#642

Note(s):
* This version of mustache generates a lot of extra UI code due to `{{#isAdmin}}` not being in scope in certain circumstances.
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. security Usually relates to something critical. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jun 3, 2021
@Martii Martii merged commit 38ddd8a into OpenUserJS:master Jun 3, 2021
@Martii Martii deleted the Issue-642showModsComment branch June 3, 2021 02:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii