Remove facter from install.rb #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no point in using which and then run that path.
It's safe to assume openssl and cgi are present.
smortex
reviewed
Jul 9, 2025
smortex
approved these changes
Jul 9, 2025
bastelfreak
added a commit
to bastelfreak/openvox-agent
that referenced
this pull request
Jul 9, 2025
This isn't needed anymore since OpenVoxProject/openvox#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the use of Facter in
install.rb. It drops Solaris support and then rewrites the Windows detect to useRUBY_PLATFORMinstead. It then also drops the prereq checking since that doesn't really serve a purpose anymore.