Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMAND_CLASS_CENTRAL_SCENE #367

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 71 comments
Closed

COMMAND_CLASS_CENTRAL_SCENE #367

GoogleCodeExporter opened this issue Mar 14, 2015 · 71 comments
Assignees
Milestone

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Use the BeNext Scene Controller 
(http://www.benext.eu/en/products/scene-controller/)

What is the expected output? What do you see instead?
Activate a scene when pushing a button

What version of the product are you using? On what operating system?
Rev 903 on linux

What branch of the code were you using? (if you just followed the
instructions on the source checkout page, then say trunk.. if you checked
out a branch, please let us know what branch it was)
Trunk

Please include the file OZW_Log.txt from your program. Make sure the file
zwcfg*.xml is NOT present.

Please provide any additional information below.

Hello,
It seems that the command class 0x5b is not supported.
Log message: ApplicationCommandHandler - Unhandled Command Class 0x5b

The node is Node018

Thanks you !

Original issue reported on code.google.com by tmartine...@gmail.com on 17 Sep 2014 at 12:30

Attachments:

@GoogleCodeExporter
Copy link
Author

It's a new CC if never heard of. We would need to reverse engineer the 
protocol. I imagine it would be straight forward. Let me know if your willing 
to help out with that. 

Original comment by jus...@dynam.ac on 17 Sep 2014 at 7:04

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

Thanks for your reply.
Tell me what i need to do for help ?

Original comment by tmartine...@gmail.com on 17 Sep 2014 at 7:08

@GoogleCodeExporter
Copy link
Author

I need to create a skeleton class first. I'm a bit backed up in work at the 
moment, but I'll try to get to it next week. 

Original comment by jus...@dynam.ac on 20 Sep 2014 at 4:41

@GoogleCodeExporter
Copy link
Author

Hello,
I've made the changes to integrate this Command Class.
Here is the patch and the files.
I've integrate too the BeNext Scene Controller.
Thanks you

Original comment by tmartine...@gmail.com on 12 Oct 2014 at 8:03

Attachments:

@GoogleCodeExporter
Copy link
Author

thats. Its a start. But I wouldn't tie it into the Scene infrastructure, but 
rather expose ValueID's for each Scene.

Can you explain why you made changes to the Device_Config.xml file? These 
mappings are dictacted by Z-Wave, so they shouldn't need to be altered. (and 
devices that support Optional command classes would still work without having 
to specify additional CC's here). 

Also, I suspect the CentralScene class would support a Capabilities_Get message 
that would at least indicate how many scenes the device supports. I'd like to 
check that out as well. 

Original comment by jus...@dynam.ac on 15 Oct 2014 at 1:05

@GoogleCodeExporter
Copy link
Author

Original comment by jus...@dynam.ac on 15 Oct 2014 at 2:54

  • Added labels: Milestone-1.4

@GoogleCodeExporter
Copy link
Author

Hi,
I've used your patch as a good start to the CentralScene, but made a few 
changes -
1) Scenes are exported as ValueInts.
2) the int represents the time when the Scene should be activated. 
3) I've put in some testing code to try to figure out the Capabilities decode. 
4) till we get Capabilities figured out - You need to specify the number of 
Scenes supported in the device config file via the option scenecount. 

I'd apriciate some testing/feedback -
1) Please remove the SceneController from your network - remove zwcfg_*.xml and 
restart your OZW app.
2) Include the Controller via whatever addnode function.
3) For the BeNext Scene Controller - Perform some testing to make sure the 
ValueID's are exposed and notifications are sent when you click a scene.
4) Send me (or attach to Issue 367) the full log file so I can see if we can 
figure out the Capabilities decode. 

Cheers


Original comment by jus...@dynam.ac on 9 Jan 2015 at 7:18

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Hello,
I've made some test with your version and it's working very well !!
I've removed the zwcfg* file ans restart my OZW app.
All work as expected.
Here is my log file, sorry it's big but i've 35 nodes in my network.
Do you need something else ?
Thanks you very much !!

Cheers

Original comment by tmartine...@gmail.com on 12 Jan 2015 at 9:35

Attachments:

@GoogleCodeExporter
Copy link
Author

Unfortunately it was asleep, and we never got to the QueryStage to check the 
capabilities. Can you retry, but after letting OZW query the other nodes, then 
press and hold any button for 18 seconds(!). This will force a wakeup according 
to the manual. 

Original comment by jus...@dynam.ac on 15 Jan 2015 at 12:53

@GoogleCodeExporter
Copy link
Author

Any chance to retest?

Original comment by jus...@dynam.ac on 20 Jan 2015 at 6:42

@GoogleCodeExporter
Copy link
Author

Hello,
I've just retest. I have exclude and include it again.
Here is the full log, the node id is 65.
Thanks you

Original comment by tmartine...@gmail.com on 21 Jan 2015 at 12:30

Attachments:

@GoogleCodeExporter
Copy link
Author

Hello,
My last file was wrong. My patch was already applied.

With your version, that doesn't work as expected, i always have an error when i 
press a button :

Node065, No ValueID created for Scene X (X: Scene Number)

Here is the full log, the node id is 65.

Thanks you

Original comment by tmartine...@gmail.com on 24 Jan 2015 at 11:39

Attachments:

@GoogleCodeExporter
Copy link
Author

Could you apply this patch and send me the output.(its on top of Revision 1003 
but should apply to earlier versions as well)

Make sure you remove the zwcfg_*.xml file and do a wakeup after OZW is started 
up (press and hold any button for 18 seconds)


Original comment by jus...@dynam.ac on 1 Feb 2015 at 5:54

Attachments:

@GoogleCodeExporter
Copy link
Author

Hello, thanks you.
Here is the new output.(Node id 65)

Original comment by tmartine...@gmail.com on 1 Feb 2015 at 7:08

Attachments:

@GoogleCodeExporter
Copy link
Author

Ok. I see whats going on now:
2015-02-01 19:51:22.852 Info, Node065, Optional command classes controlled by 
node 65:
2015-02-01 19:51:22.852 Info, Node065, CentralScene - Created 1
2015-02-01 19:51:22.852 Info, Node065, COMMAND_CLASS_CENTRAL_SCENE

This Device doesn't implement CENTRAL_SCENE, but rather controls it. This is 
only partially supported by OZW. 

Attached patch should get you going. Please apply over a clean copy of revision 
1003

Original comment by jus...@dynam.ac on 2 Feb 2015 at 1:01

Attachments:

@GoogleCodeExporter
Copy link
Author

Hello, i've applied the patch to a clean copy.
Here is the logs but i don't see any changes.
Thanks you

Original comment by tmartine...@gmail.com on 2 Feb 2015 at 8:34

Attachments:

@GoogleCodeExporter
Copy link
Author

Actually its working now. You should see some new ValueID's exported - "Scene 
Count" and "Scene 1" to "Scene 16"

I'm also seeing that its responding to one of the Capability tests I've 
included:
Received: 0x01, 0x09, 0x00, 0x04, 0x00, 0x41, 0x03, 0x5b, 0x02, 0x08, 0xe1

the 0x5b is the CentalScene CC
the 0x02 I assume is a Capability Report Message
and the 0x08 would be I assume the Number of Scene's it supports. But in this 
case, its half of what the SceneController actually reports, but considering it 
duplicates 8 buttons with a doubleclick, I'm wondering if this is a bug or not. 
Neverless, the Config File works around that issue. 

Please try revision 1006 with the following tests:
1) Remove zwcfg_*.xml and restart
2) Restart with zwcfg_*.xml present
3) apply patch "remove_scene_controller_config.patch", remove zwcfg_*.xml and 
restart.

On tests 1 and 2 you should see a Scene Count ValueID with a value of 16, and 
16 ValueID's named "Scene <x>"
On tests 3 you should see a Scene Count ValueID with a value of 8 and 8 
ValueID's named "Scene <x>"

if all works well, you can revert the patch in 3 by typing "svn revert 
config/manufacturer_specific.xml"

Many Many Thanks for your testing. Its really appreciated.... Hopefully this 
should complete it. 



Original comment by jus...@dynam.ac on 3 Feb 2015 at 6:38

Attachments:

@GoogleCodeExporter
Copy link
Author

Hello,
Thanks you it seems to work now !
I'm still having an issue but i don't if it's related to openzwave or 
python-openzwave :
when i push a button, i have this error message :
Exception KeyError: (91,) in 'libopenzwave.notif_callback' ignored

Original comment by tmartine...@gmail.com on 3 Feb 2015 at 8:01

@GoogleCodeExporter
Copy link
Author

Hello, I didn't find a way to make it work.
I always have this warning when a push a button : No ValueID created for Scene 
1 (or 2,3...)
Thanks you !

Original comment by tmartine...@gmail.com on 22 Feb 2015 at 11:33

@GoogleCodeExporter
Copy link
Author

can you attach a log?

Original comment by jus...@dynam.ac on 22 Feb 2015 at 2:04

@GoogleCodeExporter
Copy link
Author

Here are the log and the zwcfg xml file
Thanks you !

Original comment by tmartine...@gmail.com on 22 Feb 2015 at 2:18

Attachments:

@variousred
Copy link

@sayegh I will post this when i get home this evening.

@domlen
Copy link

domlen commented Dec 13, 2016

Hi all, just came across the same issue while trying to get a Popp 009303 Battery Wall Controller to work with Home Assassinate and OZW. It's correctly recognized in the OZWCP and I added a Screenshot of the current settings: screenshot 2016-12-13 22 37 30

This is what I get in the OZWCP while pressing button 1 and then button 3:
2016-12-13 22:38:50.133 Detail, Node004, Received: 0x01, 0x0b, 0x00, 0x04, 0x00, 0x04, 0x05, 0x5b, 0x03, 0xd0, 0x00, 0x01, 0x78 2016-12-13 22:38:50.134 Detail, 2016-12-13 22:38:50.135 Info, Node004, Received Central Scene set from node 4: scene id=1 in 0 seconds. Sending event notification. 2016-12-13 22:38:50.136 Warning, Node004, No ValueID created for Scene 1 2016-12-13 22:38:54.335 Detail, Node004, Received: 0x01, 0x0b, 0x00, 0x04, 0x00, 0x04, 0x05, 0x5b, 0x03, 0xd1, 0x00, 0x03, 0x7b 2016-12-13 22:38:54.337 Detail, 2016-12-13 22:38:54.337 Info, Node004, Received Central Scene set from node 4: scene id=3 in 0 seconds. Sending event notification. 2016-12-13 22:38:54.338 Warning, Node004, No ValueID created for Scene 3

For me this looked quiet promising, since I have a get an ID and it said that an event notification will be send. But in Home Assistent and the OZW_Log.txt the following happens:
016-12-13 22:04:41.540 Detail, Node004, Received: 0x01, 0x0b, 0x00, 0x04, 0x00, 0x04, 0x05, 0x5b, 0x03, 0xba, 0x00, 0x01, 0x12 2016-12-13 22:04:41.540 Detail, 2016-12-13 22:04:41.540 Info, Node004, ApplicationCommandHandler - Unhandled Command Class 0x5b

I'm very new to the whole ZWave thong and I just wanted to share my finding. Maybe they can help you.
I'm happy to test or answer anything - just let me know!

@sayegh
Copy link

sayegh commented Dec 14, 2016

Okay, another try for Nodon Soft Remote. Try to add this to your configuration file for the device:

<CommandClass id="91" name="COMMAND_CLASS_CENTRAL_SCENE" version="1" request_flags="4" innif="true" scenecount="0">
        <Instance index="1" />
        <Value type="int" genre="system" instance="1" index="0" label="Scene Count" units="" read_only="true" write_only="false" verify_changes="false" poll_intensity="0" min="-2147483648" max="2147483647" value="0" />
        <Value type="int" genre="user" instance="1" index="1" label="Button Bullet" units="" read_only="true" write_only="false" verify_changes="false" poll_intensity="0" min="-2147483648" max="2147483647" value="0" />
        <Value type="int" genre="user" instance="1" index="2" label="Button Plus" units="" read_only="true" write_only="false" verify_changes="false" poll_intensity="0" min="-2147483648" max="2147483647" value="0" />
        <Value type="int" genre="user" instance="1" index="3" label="Button Circle" units="" read_only="true" write_only="false" verify_changes="false" poll_intensity="0" min="-2147483648" max="2147483647" value="0" />
        <Value type="int" genre="user" instance="1" index="4" label="Button Minus" units="" read_only="true" write_only="false" verify_changes="false" poll_intensity="0" min="-2147483648" max="2147483647" value="0" />
</CommandClass>

If you don't have a config file yet, look here:
https://github.com/jeedom/plugin-openzwave/blob/master/ressources/openzwave/config/nodon/crc360xSofremote.xml

This may also be an indication how to proceed with other devices - we're going to try the Fibaro button next.

Edit: Each button has its own OZW value. Here's the Z-Wave spec part that indicates the meaning of the integer values for a button (3 = pressed 2 times for example):

screen shot 2016-12-14 at 13 24 32

@KptnKMan
Copy link

@sayegh Could you provide any details or instructions on how you were able to configure this?

I'm still trying to configure my Fibaro Button FGPB-101, and I'd really like to find out how to get it working.

@sayegh
Copy link

sayegh commented Dec 14, 2016

@KptnKMan It's a file in the OZW config directory. You need access to the file system; anyway, I obviously don't know the location of the config directory on your system.
Once you're there, follow this thread (and probably make above changes):
#755

@KptnKMan
Copy link

@sayegh I found the file that is used on my system, and I'm pretty sure it reflects as this file:

https://github.com/jeedom/plugin-openzwave/blob/master/ressources/openzwave/config/fibaro/fgpb101.xml

Is there anything I can provide to provide debug or info?

@nechry
Copy link
Member

nechry commented Dec 16, 2016

for your record files in this folder: https://github.com/jeedom/plugin-openzwave/tree/master/ressources are no more updated. It's a obsolete folder.

@KptnKMan
Copy link

@nechry Thanks, I have compared the version of fgpb101.xml to my local version, which I believe it the latest version shipped with HA+OZW:
/srv/hass/src/python-openzwave/openzwave/config/fibaro/fgpb101.xml

They appear to be identical, does this mean that there is another issue with setting scenes?

@sayegh
Noted above is my config directory, the file was already included there.

I'm just trying to get this button working correctly, so that I can configure scenes using it.

Any help would be greatly appreciated.

@sayegh
Copy link

sayegh commented Dec 16, 2016

@KptnKMan So we tried the Fibaro button, and apparently OZW sees it and provides a scene value when the button is pressed.
However, the scene values do not match what I understood from the spec so far, they are 4 digit integers and not these 0...7 values mentioned above.
No issue for us, since we are developing the gateway software and can easily adapt to any values, but I can imagine other software having issues with these values. Note, this is my first impression, and it's not impossible I got it all wrong. :-)

Edit: I also checked the values if the 0...7 values were somewhere hidden in the bits so we can mask them out, but I didn't find them.

@ZyberSE
Copy link

ZyberSE commented Dec 19, 2016

I just bought The Button without doing any research before hand (stupid...), can I get it working somehow (not assigning it to another z-wave actor directly).

@nechry
Copy link
Member

nechry commented Dec 20, 2016

we do some work in a beta branch:
https://github.com/jeedom/plugin-openzwave/blob/beta/resources/python-openzwave/openzwave/cpp/src/command_classes/CentralScene.cpp
and the results are quite good.

@ZyberSE
Copy link

ZyberSE commented Dec 20, 2016

@nechry thank you for your reply. Would I be able to check out a beta version of your implementation, build it and run it just as the main version? I'm using it in my Home-Assistant.io setup and are looking for ways to have simple, physical buttons to manually trigger some stuff.
If I could get it working before the v1.6 release I would be super happy =)

@nechry
Copy link
Member

nechry commented Dec 20, 2016

Replace your actual .cpp and .h for the CentralScene and rebuild the library. We actually do other tweeting on driver, node but it's in alpha. So the safe way to try is just take the CC CentralScene from jeedom branch.

@philk
Copy link

philk commented Dec 20, 2016

I'm using that branch with home-assistant and it's fine. python-openzwave has some complaints and Hass doesn't see the scene events but it doesn't break anything. I'm using a god awful hack (tailing the ozw_log via a script) to trigger actions based on scenes for now.

@luukengelen
Copy link

Hi, Can anyone tell me how to include these .cpp files to homeassistant? I have build a new library, but i don't know how this is used in homeassisatant.

@KptnKMan
Copy link

Hi, is anyone able to provide some instructions for those of us who would like to test?

Seems like a good idea. 👍

@YoctoFIM
Copy link

YoctoFIM commented May 2, 2017

hello guys @sayegh @nechry @KptnKMan @Fishwaldo

Actually I am stuck on an issue
I am using Nodon soft remote and when I launch the application (MinOZW) I only get this, knowing that I used the in patch #1125 for CentralScene.cpp

NodeID: 13 
 	 ValueLabel: Basic 
		 ValueType: 1 
		 ValueUnits:  
		 ValueMin: 0 
		 ValueMax: 255 
------------------------------------------------------------
	 ValueLabel: Level 
		 ValueType: 1 
		 ValueUnits:  
		 ValueMin: 0 
		 ValueMax: 255 
------------------------------------------------------------
	 ValueLabel: Bright 
		 ValueType: 8 
		 ValueUnits:  
		 ValueMin: 0 
		 ValueMax: 0 
------------------------------------------------------------
	 ValueLabel: Dim 
		 ValueType: 8 
		 ValueUnits:  
		 ValueMin: 0 
		 ValueMax: 0 
------------------------------------------------------------
	 ValueLabel: Ignore Start Level 
		 ValueType: 0 
		 ValueUnits:  
		 ValueMin: 0 
		 ValueMax: 0 
------------------------------------------------------------
	 ValueLabel: Start Level 
		 ValueType: 1 
		 ValueUnits:  
		 ValueMin: 0 
		 ValueMax: 255 
------------------------------------------------------------
	 ValueLabel: Switch All 
		 ValueType: 4 
		 ValueUnits:  
		 ValueMin: 0 
		 ValueMax: 0 
------------------------------------------------------------
	 ValueLabel: Scene Count 
		 ValueType: 3 
		 ValueUnits:  
		 ValueMin: -2147483648 
		 ValueMax: 2147483647 

how can I use the scenes to make use of the remote ? how do I access sceneIDs ? do I have to create scenes through the manager ?
I am able to see this line when I press a button:
"Node013, Received Central Scene set from node 13: scene id=2 with key Attribute 2. Sending event notification."
any help please ?
Thank you

@IvanSurovegin
Copy link

Hello!
I am using ZME_KFOB (4 buttons) with latest release of openzwave (1.4.164) and initially got a problem with CentralScene support which is fixed by the patch
#1125 (comment)

With this patch ZME_KFOB can be succesfully used with one exception: if we restart host (controller power off/on, library is started from scratch), the library doesn't react on KFOB keys pressing and
just shows a report about not handled CC (full log is in attached problem_report.txt):
2018-06-06 08:32:27.597 Info, Node004, ApplicationCommandHandler - Unhandled Command Class 0x5b

I haven't found any info about such problem - only this topic. Changes in XML (as above) didn't help.
I have checked the code around the place of the info message and prepared a small fix which helped me,
problem_report_solution.txt shows how it works now.

My patch is attached. Probably it is not so correct from the library point of view but works and probably helps somehow somebody.
Also i am interested in oppinion of the library developes on the problem and on the fix.
Thanks!
problem_report.txt
problem_report_solution.txt
problem_patch.txt

@Fishwaldo Fishwaldo added this to the Version 1.6 milestone Nov 14, 2018
@Fishwaldo
Copy link
Member

Hello!
I am using ZME_KFOB (4 buttons) with latest release of openzwave (1.4.164) and initially got a problem with CentralScene support which is fixed by the patch
#1125 (comment)

With this patch ZME_KFOB can be succesfully used with one exception: if we restart host (controller power off/on, library is started from scratch), the library doesn't react on KFOB keys pressing and
just shows a report about not handled CC (full log is in attached problem_report.txt):
2018-06-06 08:32:27.597 Info, Node004, ApplicationCommandHandler - Unhandled Command Class 0x5b

I haven't found any info about such problem - only this topic. Changes in XML (as above) didn't help.
I have checked the code around the place of the info message and prepared a small fix which helped me,
problem_report_solution.txt shows how it works now.

My patch is attached. Probably it is not so correct from the library point of view but works and probably helps somehow somebody.
Also i am interested in oppinion of the library developes on the problem and on the fix.
Thanks!
problem_report.txt
problem_report_solution.txt
problem_patch.txt

You just need to wake up the keyfob after restarting your device.

@Fishwaldo
Copy link
Member

This is completed.

@KptnKMan
Copy link

KptnKMan commented Dec 3, 2018

Would like to know:

Is there a PR or release of OZW that integrates these changes?

Would really like to have a clear reference of what this completes issue means.

Thanks.

Edit: As far as I can tell, the PR #1124 is added by fishwaldo at a5305f0. Is this correct? 😃

@Fishwaldo
Copy link
Member

It’s completed in the Dev Branch which will be merged with master onces the remaining items on Milestone 1.6 are complete (and we will make a release then)

@stromnet
Copy link
Contributor

stromnet commented Dec 3, 2018

Woho, very good news! Great job! :) Will see if I can give it a try :)

@KptnKMan
Copy link

KptnKMan commented Dec 3, 2018

@Fishwaldo thanks very much. Much appreciated. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests