Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaderboard crawler by removing Goerli testnets #18

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

renbou
Copy link
Contributor

@renbou renbou commented Mar 27, 2024

Hello! Since Goerli was deprecated and removed from Ethernaut in OpenZeppelin/ethernaut#699, it should also be removed from the leaderboard crawler. Currently, since Goerli has been completely disabled, the crawler isn't able to work at all (alchemy Goerli addresses don't resolve to an IP anymore). As an incomplete fix for this I've simply removed the Goerli networks from the networkDetails.json file. Tested this with Mumbai, seems to be working locally.

I've also pulled all the necessary updates from the update branch (took the files which appeared in git diff --name-only main), so this should be good to go.

Please merge this until someone is able to write a proper patch with the complete removal of the Goerli testnets and addition of the Optimism & Arbitrum Sepolia testnets. At least this way the leaderboard will be getting synced for Mumbai & Sepolia...

@renbou renbou changed the title Update JSON files from update branch, leave only mumbai & sepolia in … Fix leaderboard crawler by removing Goerli testnets Mar 27, 2024
@jdetychey
Copy link

awesome, thank you for that!

@renbou
Copy link
Contributor Author

renbou commented Apr 1, 2024

@xaler5 @JithinKS97 Hi! You guys seem to be the main maintainers, can this get merged so that the leaderboard starts working again?

@JithinKS97
Copy link
Contributor

JithinKS97 commented Apr 1, 2024

After removing goerli from the config, have you ran the crawler again to correct the data? @renbou

@renbou
Copy link
Contributor Author

renbou commented Apr 1, 2024

I won't be able to run it properly since it requires a key for your HubSpot API, no? If it's public I can try setting it up and running it, I'm not too familiar with HubSpot. Other than that I've tried launching it to check that it properly works, but for that I've commented out the calls to the aliasing API.

@jdetychey
Copy link

Looks like a catch22 here. Ethernaut is used by several education programs for blockchain and solidity. This leaderboard is very handy to check and gamify the progression.
Is the data corrected when you run the crawler after the fix with the proper API key @JithinKS97 ?

@JithinKS97
Copy link
Contributor

@jdetychey @renbou I no longer maintain the repo. I had it when my current organization had a collaboration with Openzeppelin. I think we might need someone from Openzeppelin to run it since they own the keys. @xaler5 Can you help us?

@xaler5
Copy link
Collaborator

xaler5 commented Apr 11, 2024

@GianfrancoBazzani is taking care of this PR currently syncing old blocks of all chains with the leaderboard. It will take some time please bear with us :)

Copy link
Member

@GianfrancoBazzani GianfrancoBazzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay guys, we had to synch all pending blocks

@GianfrancoBazzani GianfrancoBazzani merged commit ace5e8b into OpenZeppelin:main Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants