-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaderboard crawler by removing Goerli testnets #18
Fix leaderboard crawler by removing Goerli testnets #18
Conversation
awesome, thank you for that! |
@xaler5 @JithinKS97 Hi! You guys seem to be the main maintainers, can this get merged so that the leaderboard starts working again? |
After removing goerli from the config, have you ran the crawler again to correct the data? @renbou |
I won't be able to run it properly since it requires a key for your HubSpot API, no? If it's public I can try setting it up and running it, I'm not too familiar with HubSpot. Other than that I've tried launching it to check that it properly works, but for that I've commented out the calls to the aliasing API. |
Looks like a catch22 here. Ethernaut is used by several education programs for blockchain and solidity. This leaderboard is very handy to check and gamify the progression. |
@jdetychey @renbou I no longer maintain the repo. I had it when my current organization had a collaboration with Openzeppelin. I think we might need someone from Openzeppelin to run it since they own the keys. @xaler5 Can you help us? |
@GianfrancoBazzani is taking care of this PR currently syncing old blocks of all chains with the leaderboard. It will take some time please bear with us :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for the delay guys, we had to synch all pending blocks
Hello! Since Goerli was deprecated and removed from Ethernaut in OpenZeppelin/ethernaut#699, it should also be removed from the leaderboard crawler. Currently, since Goerli has been completely disabled, the crawler isn't able to work at all (alchemy Goerli addresses don't resolve to an IP anymore). As an incomplete fix for this I've simply removed the Goerli networks from the
networkDetails.json
file. Tested this with Mumbai, seems to be working locally.I've also pulled all the necessary updates from the
update
branch (took the files which appeared ingit diff --name-only main
), so this should be good to go.Please merge this until someone is able to write a proper patch with the complete removal of the Goerli testnets and addition of the Optimism & Arbitrum Sepolia testnets. At least this way the leaderboard will be getting synced for Mumbai & Sepolia...