Add ECRecoveryMock contract #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustoL
force-pushed
the
test/ECRecoveryMock
branch
from
d0e3069 to
664c4d3
Compare
eordano
reviewed
Jan 3, 2018
test/ECRecovery.test.js
Outdated
| // Recover the signer address form the generated message and wrong signature. | ||
| assert.notEqual(web3.eth.accounts[0], await ecrecovery.recover(hashMessage('Test'), signature)); | ||
| await ecrecovery.recover(hashMessage('Test'), signature); | ||
| assert.notEqual(web3.eth.accounts[0], await ecrecovery.addrRecovered()); |
There was a problem hiding this comment.
nit: Maybe better to use accounts rather than web3.eth.accounts?
There was a problem hiding this comment.
Yes! it should be accounts, my bad, changing it!
shrugs
reviewed
Jan 4, 2018
test/ECRecovery.test.js
Outdated
| it('recover using web3.eth.sign()', async function () { | ||
| // Create the signature using account[0] | ||
| const signature = web3.eth.sign(web3.eth.accounts[0], web3.sha3('OpenZeppelin')); | ||
| const signature = web3.eth.sign(accounts[0], web3.sha3('OpenZeppelin')); |
There was a problem hiding this comment.
Can we replace this magic string ("OpenZeppelin") with a constant defined at the top of the file?
const TEST_MESSAGE = 'OpenZeppelin'
test/ECRecovery.test.js
Outdated
| const signature = web3.eth.sign(web3.eth.accounts[0], web3.sha3('OpenZeppelin')); | ||
| const signature = web3.eth.sign(accounts[0], web3.sha3('OpenZeppelin')); | ||
|
|
||
| // Recover the signer address form the generated message and signature. |
There was a problem hiding this comment.
nitpick: can we update these typos while we're at it? namely form to from both here and in other places in this file. I know that's annoying, but it'd be appreciated :D
|
although it looks like it needs a merge/rebase to get up to date |
AugustoL
force-pushed
the
test/ECRecoveryMock
branch
from
774f433 to
c73861d
Compare
|
@shrugs rebased with master |
shrugs
previously approved these changes
Jan 4, 2018
shrugs
approved these changes
Jan 4, 2018
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
Add ECRecoveryMock contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mock contract to tests the ECRecovery lib as an extension of
bytes32variables using: