Skip to content

Conversation

kookiekrak
Copy link
Contributor

@kookiekrak kookiekrak commented Mar 30, 2018

🚀 Description

Theres an extra import in ERC721Token.sol and the DeprecatedERC721.sol isn't implemented or necessary. Removing this import will reduce a file dependency in this contract.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

The DeprecatedERC721.sol isn't implemented or necessary.
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kookiekrak!

@frangio frangio merged commit 44a404a into OpenZeppelin:master Apr 3, 2018
frangio pushed a commit to frangio/openzeppelin-contracts that referenced this pull request Apr 5, 2018
The DeprecatedERC721.sol isn't implemented or necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants