Changes to data structures to fix bugs: issue #6 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add explanations. Add problems in algorithms numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some bugs in the implementations of the first few data structures in the algorithms course. In LinkedList.js the tail was not set if the element added was the last element. In Queue peek should look at the last element of the array, the next one to be popped, not the first element. In Queue, one of the tests was wrong, as the elements are stored in the reverse order in which they are added, as they are pushed on the front using unshift.
The one arguable change is in Stack.js where I think the return code should be null, when you pop or peek and empty stack, but I suppose some people could think the opposite.