Add military_status to user (fixes #373)

[hollomancer]

Description of changes

Adds a column for military_status, which is currently not present on users. This will allow the information we request regarding a military spouse / active duty in signup flow to save to the DB.

Issue Resolved

Part of fixing #373 (some frontend work needed)

It's been a while for me. Please review.

[hollomancer]

Also fixes #374

[hpjaj]

@hollomancer - You'll also need to add this new attribute to:

• the list of strong params in the users_controller: https://github.com/hollomancer/operationcode_backend/blob/master/app/controllers/api/v1/users_controller.rb#L53-L84
• admin dashboard, strong params: https://github.com/hollomancer/operationcode_backend/blob/master/app/admin/user.rb#L2-L9
• admin dashboard, index view: https://github.com/hollomancer/operationcode_backend/blob/master/app/admin/user.rb#L50-L82
• admin dashboard, create/update form: https://github.com/hollomancer/operationcode_backend/blob/master/app/admin/user.rb#L92-L119

[hpjaj]

As this is a string, is the plan to accept any string, or a specific list of strings for consistency? Meaning a specified set of four statuses, for example. I highly recommend the latter.

This way, we can enforce data integrity, hang logic on the responses, do data analysis, filtering and searching, add rules for certain statuses, etc., etc.

If the answer is yes, then we'll need to do a few extra additions in this PR before shipping it.

[hollomancer]

Yeah, I agree. Let's do it the right way.

From the frontend, current, veteran, spouse are the values provided.

[hollomancer]

I'd just need to add the check in /app/models/user.rb, is that correct?

[hpjaj]

@hollomancer - To establish the specific set of validated statuses, you'll want to:

1. Create a constant for each status here.
2. Create a constant to represent an array of all of the statuses. You'll need to include one for nil, to account for our current users, and future users, that will not have a status. For example:

CURRENT = 'current'
VETERAN = 'veteran'
SPOUSE = 'spouse'
MILITARY_STATUSES = [CURRENT, VETERAN, SPOUSE, nil]

3. In models/user.rb, Add an inclusion validation for the new :military_status attribute, for the MILITARY_STATUSES. Here is how to do that.
4. In admin/user.rb, add the set of selections to ActiveAdmin dashboard form portion. For example:

f.input :military_status, as: :select, collection: User::MILITARY_STATUSES.map { |status| [status, status].compact }.reject(&:empty?), include_blank: true

5. Add test coverage to user_test.rb testing the new inclusion validation
6. In apiary.apib, in the military_status definition, change that to something like:

Users military status, either: current, veteran, spouse, or blank

[dmarchante]

@hpjaj is this only waiting a review, or are there more changes to be made?

[hollomancer]

@dmarchante, this one's on me to finish validation appropriately.

[hollomancer]

@hpjaj, should we break this up into smaller segments?

[hpjaj]

No, let's keep all of the user model related test code in this file.

As far as disabling RuboCop, you can:

• do it like this: http://www.mindonrails.com/notes/334-disabling-and-re-enabling-a-rubocop-rule-for-a-specific-set-of-code
• add an exclusion for the test file to .rubocop.yml

The latter is slightly preferable. If you run into any issues doing it that way, due to the Metrics/ClassLength setting in .rubocop_todo.yml, then just go with the former. Not a big deal in this case.

[hpjaj]

You'll want to delete this input (we'll favor the new collection input on line 109).

[hpjaj]

Can you pls change these three to pass the three new constants, to support our validation? i.e.

assert create(:user, military_status: User::SPOUSE).valid?

[hpjaj]

Nice work @hollomancer !