Skip to content

Added 'paid' algolia filtering to search endpoint #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Added 'paid' algolia filtering to search endpoint #219

merged 2 commits into from
Oct 5, 2019

Conversation

Kandeel4411
Copy link
Collaborator

Hello!
Refers Issue #194

I have added 'paid' attribute filtering to the search endpoint using algolia filters, due to not having API key I haven't been able to test it thoroughly.

Possible issue I noticed ( unrelated to this PR ) is that the algolia query API search has a limit of 512 characters where if the user typed a really long query, it would return a 500 error

Let me know if there is anything else I can do, this is my first time 😅

@aaron-junot
Copy link
Member

@Kandeel4411 Thanks for your contribution, I'll review shortly. Regarding your comment about the 512 character limit, can you open an issue in the repo for it and I'll assign you to fixing it? I assume you're willing/able to address it considering that you brought it up 😅

Copy link
Member

@aaron-junot aaron-junot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're looking good so far! Can you please add unit tests and documentation?

The unit tests are really just checking that the application doesn't blow up in the situations where paid is included and excluded from the query. The current tests for the search endpoint already check for when it's excluded, so it should just be a simple addition of the parameter in another request and checking that the response is still 200.

The relevant documentation is located here https://github.com/OperationCode/resources_api/blob/master/app/static/openapi.yaml#L87

Copy link
Member

@aaron-junot aaron-junot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution!

@aaron-junot aaron-junot merged commit bf17ba3 into OperationCode:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants