Skip to content

Update lisa code #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Update lisa code #711

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f62e57e
update lisa code
Dominic789654 Mar 27, 2024
cfc0db2
update lisa code
Dominic789654 Mar 27, 2024
ddf3524
update lisa code
Dominic789654 Mar 27, 2024
a9d4e10
change args name
Dominic789654 Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/lmflow/pipeline/finetuner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,7 @@ def __init__(self, n_layers, interval_steps, model):
self.layers_attribute = 'model.transformer.h' # General access path
self.total_layers = len(eval('self.' + self.layers_attribute)) # Dynamically execute to get the number of layers

# Freeze all layers upon initialization
self.freeze_all_layers()
self.switch_active_layers()
self.active_layers_indices = []
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these lines should be swapped, since active_layers_indices is modified by switch_active_layers


def freeze_all_layers(self):
Expand All @@ -323,7 +322,7 @@ def freeze_all_layers(self):

def on_step_begin(self, args, state, control, **kwargs):
# Check if it's time to switch active layers, including at step 0
if state.global_step % self.interval_steps == 0 or state.global_step == 1:
if state.global_step % self.interval_steps == 0 :
self.switch_active_layers()

def switch_active_layers(self):
Expand Down