Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to copy\delete methods and (some) tag workflow #648

Merged
merged 14 commits into from
Feb 28, 2022
Merged

improvements to copy\delete methods and (some) tag workflow #648

merged 14 commits into from
Feb 28, 2022

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Feb 10, 2022

(Its still a work in progress till i comment on discord)
To allow cloning/deleting an array of frames instead of just 1

  1. if a frame has at least one of it's cel selected then it will be cloned/copied
  2. the cloned cels are intentionally placed immediately after the last selected frame
  3. if the last selected frame is part of any tag then they would be included in that tag

TAGS:

  1. fixed a bug when a tag of length 1 on frame 1 was removed in the presence of other tags
  2. add and clone frames push the upcoming tags ahead and increase the size of tag they're in
  3. movement left or right now actively interact with tags (may be made on another PR)
Demo.1.mp4

@Variable-ind Variable-ind changed the title improvements to copy and delete methods improvements to copy\delete methods and tag workflow Feb 11, 2022
@Erevoid
Copy link
Member

Erevoid commented Feb 18, 2022

Hello there! From the changes you proposed we're going to implement the ability to clone/delete multiple frames and the displacement of the tags when a new cel is added before them. We already have something in mind for the rest of the suggestions you proposed in this PR and we believe they will be more user friendly. I recommend removing thοse from this PR for now until we discuss them ever further for future implementations.

PS: Keep in mind that this kind of PR which proposes lots of changes at once is not optimal because there's always a risk that a lot of work of yours will be lost. If you want to avoid that in the future try to keep your PRs even smaller, with only one change per PR, for everyone's convenience!

@Variable-ind Variable-ind changed the title improvements to copy\delete methods and tag workflow improvements to copy\delete methods and (some) tag workflow Feb 26, 2022
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@OverloadedOrama OverloadedOrama merged commit bec3011 into Orama-Interactive:master Feb 28, 2022
@Variable-ind Variable-ind deleted the frame-select-improvements branch March 1, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants