243-enabled-different-kinds-of-legend

[jacques-lebourgeois]

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #243

Closes #245 (via #246)

Description

Specific legend holders

Motivation & Context

Outsourcing captions should make it possible to

• position legends vertically or
• separate them into different containers

Types of change

• New feature (non-breaking change which adds functionality)

Test checklist

Please check that the following tests projects are still working:

• docs/examples
• test/angular-ngx-echarts
• test/angular-echarts
• test/html
• test/react
• test/vue
• test/examples/bar-line-chart
• test/examples/single-line-chart
• test/examples/timeseries-chart

[netlify]

✅ Deploy Preview for ods-charts ready!

Name	Link
🔨 Latest commit	0d7b923
🔍 Latest deploy log	https://app.netlify.com/sites/ods-charts/deploys/66e02daecf02ea0008ae6c19
😎 Deploy Preview	https://deploy-preview-244--ods-charts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[louismaximepiton]

Using this solution, should we handle the tooltip legend as well ? I don't know if this is feasible automatically and if it should be done in here but something like:

On the JS part, haven't checked in details, but it seems to work pretty well. Some small concerns (that might not be related to the PR):

• If a series is empty, the legend appear on the bottom but not in the tooltip, are we fine with that even if it's not consistent?
• If there is no defaultLegendHolder, some elements of the legend could be hidden, do you think we should handle that use case?

[jacques-lebourgeois]

Using this solution, should we handle the tooltip legend as well ? I don't know if this is feasible automatically and if it should be done in here but something like ...

I hadn't thought of this use case. I think it's a good idea. But it seems rather complex to do simply in this Merge Request, don't you think? We can wait for a project need before implementing it, what do you think? Note that it's always possible for the project to fully customize the tooltip content.

[jacques-lebourgeois]

If a series is empty, the legend appear on the bottom but not in the tooltip, are we fine with that even if it's not consistent?

Agree, but it is not specific to this PR : cf code of https://codepen.io/jacques-lebourgeois/pen/rNgzbXQ

it should be treated as a bug or a new feature to be able to configure legends with an option hide empty series legend

[jacques-lebourgeois]

If there is no defaultLegendHolder, some elements of the legend could be hidden, do you think we should handle that use case?

Not sure because I wouldn't know which container to choose. What's more, it may be the developer's wish not to display legend for so-called “technical” series.

[louismaximepiton]

LGTM 🚀

[julien-deramond]

@jacques-lebourgeois In https://ods-charts.netlify.app/examples/bar-chart, in the "Vertical grouped bar chart", we had the possibility to switch between "ODS Charts legend" and "Apache ECharts legend". That's not the case anymore in this PR, and so it's not possible neither to change here the legend orientation. Is it voluntary?

[jacques-lebourgeois]

@jacques-lebourgeois In https://ods-charts.netlify.app/examples/bar-chart, in the "Vertical grouped bar chart", we had the possibility to switch between "ODS Charts legend" and "Apache ECharts legend". That's not the case anymore in this PR, and so it's not possible neither to change here the legend orientation. Is it voluntary?

You're right, thanks.

The selector of type legend renderer is now hidden when there is no legend.

But I forgot a context in my css selector and then hide this selector for all the charts.

Sorry, this is fixed I hope

[julien-deramond]

Neat @jacques-lebourgeois! Good job.
I've made some minor modifications in f32553a, 83d25d5, 715b4e1, and cd8cc09.
I let you check that everything's OK, and then I can merge and release a new alpha version 🚀