-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
245-add-vertical-legends-management-in-documentation-tool #246
245-add-vertical-legends-management-in-documentation-tool #246
Conversation
305d788
to
fb4e034
Compare
57409d7
to
1a867d1
Compare
1a867d1
to
98a2598
Compare
00b6d66
to
b068c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't figure our why the donut and pie charts don't work with this PR while rebasing and removing the legend behavior in their code. I must miss something in here.
b068c17
to
3675c59
Compare
946c124
to
b5ab6a5
Compare
3675c59
to
11882bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes for pie and donut charts. LGTM 🚀
|
d57b1b4
into
243-enabled-different-kinds-of-legend
Related issues
#245
Description
Add legend orientation
Motivation & Context
Feature added in previous PR
Types of change
Test checklist
Please check that the following tests projects are still working:
docs/examples
test/angular-ngx-echarts
test/angular-echarts
test/html
test/react
test/vue
test/examples/bar-line-chart
test/examples/single-line-chart
test/examples/timeseries-chart