Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

245-add-vertical-legends-management-in-documentation-tool #246

Conversation

jacques-lebourgeois
Copy link
Member

Related issues

#245

Description

Add legend orientation
image

Motivation & Context

Feature added in previous PR

Types of change

  • New feature (non-breaking change which adds functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@jacques-lebourgeois jacques-lebourgeois self-assigned this May 29, 2024
@jacques-lebourgeois jacques-lebourgeois added the documentation Improvements or additions to documentation label May 29, 2024
@jacques-lebourgeois jacques-lebourgeois linked an issue May 29, 2024 that may be closed by this pull request
2 tasks
@jacques-lebourgeois jacques-lebourgeois linked an issue May 29, 2024 that may be closed by this pull request
2 tasks
@jacques-lebourgeois jacques-lebourgeois changed the base branch from 243-enabled-different-kinds-of-legend to main May 29, 2024 12:36
@jacques-lebourgeois jacques-lebourgeois changed the base branch from main to 243-enabled-different-kinds-of-legend May 29, 2024 12:36
@jacques-lebourgeois jacques-lebourgeois force-pushed the 245-add-vertical-legends-management-in-documentation-tool branch from 305d788 to fb4e034 Compare May 29, 2024 14:16
@jacques-lebourgeois jacques-lebourgeois force-pushed the 243-enabled-different-kinds-of-legend branch from 57409d7 to 1a867d1 Compare June 14, 2024 13:36
@julien-deramond julien-deramond marked this pull request as draft June 17, 2024 05:42
@jacques-lebourgeois jacques-lebourgeois force-pushed the 243-enabled-different-kinds-of-legend branch from 1a867d1 to 98a2598 Compare June 21, 2024 15:32
@jacques-lebourgeois jacques-lebourgeois force-pushed the 245-add-vertical-legends-management-in-documentation-tool branch 2 times, most recently from 00b6d66 to b068c17 Compare June 21, 2024 15:38
@jacques-lebourgeois jacques-lebourgeois marked this pull request as ready for review June 21, 2024 15:39
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure our why the donut and pie charts don't work with this PR while rebasing and removing the legend behavior in their code. I must miss something in here.

@jacques-lebourgeois jacques-lebourgeois force-pushed the 245-add-vertical-legends-management-in-documentation-tool branch from b068c17 to 3675c59 Compare September 2, 2024 12:40
@jacques-lebourgeois jacques-lebourgeois force-pushed the 243-enabled-different-kinds-of-legend branch from 946c124 to b5ab6a5 Compare September 2, 2024 12:43
@jacques-lebourgeois jacques-lebourgeois force-pushed the 245-add-vertical-legends-management-in-documentation-tool branch from 3675c59 to 11882bc Compare September 2, 2024 12:51
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes for pie and donut charts. LGTM 🚀

@julien-deramond
Copy link
Member

I've spotted something weird when there's no legend: we save some space for it even if it is not rendered.
Maybe we don't care, that's up to you to say :)

2024-09-04 08 46 19

@jacques-lebourgeois
Copy link
Member Author

we save some space for it even if it is not rendered

f815ede

@jacques-lebourgeois jacques-lebourgeois merged commit d57b1b4 into 243-enabled-different-kinds-of-legend Sep 5, 2024
1 check passed
@jacques-lebourgeois jacques-lebourgeois deleted the 245-add-vertical-legends-management-in-documentation-tool branch September 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vertical legends management in documentation tool
3 participants