[P1][Bug][a11y] Focus order of "customization" bottom sheet is incorrect #703
Labels
Comments
pya35
added
🐞 bug
pylapp
pushed a commit
that referenced
this issue
Feb 23, 2024
…d content in bottom sheet Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
|
OK sur 0.18 (1708889908) |
1 task
pylapp
added a commit
that referenced
this issue
Mar 6, 2024
* Udpate tools for somana support * Bump version * [#680] Add generation of Git tags in qualif build (#681) * feat(#680): tooling - add generation of Git tags in qualif build Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: tooling - update dependencies Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#583] Vocalize buttons selected state (#686) * chore: dependencies - update CocoaPods version Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * fix(#583): vocalization of buttons selected states Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [Tools] Disable tags management in Fastlane CI/CD chain Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#558] Add ODSEmptyState module (#688) * Module and screen in demo app with options * Add documentation * Update changelog * Rename images and set the right default image * review * Update asset name and update lit of assets in Notice.txt * [#581] Bottom sheet states Voice Over vocalization (#687) * fix(#581): bottom sheet states Voice Over vocalization (labels and hints) Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor(#581): review - apply comments Applied: - #687 (comment) - #687 (comment) 0 Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#428] Fix expanding bottom sheet on ipad (#694) * fix, set the relative width to 100% and set on ipa the bottomsheet position like iphone (bottom Leading) * Rebase on qualif branch * Update changelog * review fix typo Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#689] About module, add error views for "more apps" and "app news" features (#695) * Use empty view for more apps and appnews * Update changelog * Add missing Accessibility statement file * review Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Add missing file * [Docs] Add Google Tag Manager (#697) * Add google tag manager Reviewed-by: Julien Déramond <julien.deramond@@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#693] Update background color of the navigation and tab bars (#701) * Update color in navigation and tab bars, and remove unused colors * Update change log Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Fix by updating with right text (#706) * [#707] Spacer indicator missing on spacing guidelines page #708 Fix by renaming color (#708) Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#704] On "Customize" bottom sheets, the hint is reversed V2 (#711) * Fix second language file * mend * [#684] Create apps recirculation as a module (no more available in about module) (#705) * [#704] On "Customize" bottom sheets, the hint is reversed V2 (#711) * Fix second language file * mend * Update recirculation backend and business api * Add documentation for module and update about documentation * Update changelog and make doc visible in menu * cosmetic on docs * review * Update assets * review : merge failure * review... * review update again the code to remove a static Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#712] Update the tab bar configuration to see the separator (#713) Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#703] Change the order of the accessibility focus between header and content in bottom sheet Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#714] Update the demo configuration for recirculation module (#718) * Rename use local mock * Update flatten apps wording * Upodate wording * review Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#727] Migration to GitLab CI runner (#728) * feat: add tags for both CI builds and TestFlight uploads Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * feat: CI and release tags, update doc Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * feat: Git tags management through HTTP, get hash of current commit Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: tests execution Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: add xcode-install tool for lanes Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * tool: move SwifLint YAML for better execution in CI/CD Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * test: fix failing tests (isssues with l10n and default setup Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * tool: define Xcode version for builds Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: more details about sender in hooks notifications Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: improve messages Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: SwiftLint for more folders Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: manage more SwiftLint warnings Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: more messages Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: from build_app to gym Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: disable automatic signing Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Manage internal prov profiles Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * fix: bad name of lane Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * fix: remove new line adter commit sha for tags Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * fix: change API path Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: more magic Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: clean up Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: clean up after rebease - Rename data structures, protocols and variables for recirculation module - Remove dead code - Remove linter warnings Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: disable temporary upload Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * doc: fix broken link in changelog Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * fix: doublon lane Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: add doc and read from runner the commit to use for tags Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Add doc, controls for Git tags Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: indentation, lane params Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: more logs Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: less private lanes Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * New build number computation Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Refactor indent Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore(#727): update CHANGELOG Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * doc(#727): update documentation about CI/CD chain Co-authored-by: Pierre-Yves Lapersonnee <pierreyves.lapersonne@orange.com> Co-authored-by: Florent Maitre <florent.maitre@orange.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore(#727): clean up Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Co-authored-by: Florent Maitre <florent.maitre@orange.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Refactor iOS documentation (#725) * [#729] Fix lane adding Apps Plus URL to app PLIST (#736) * chore(#729): more debug Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore(#729): fix path to PLIST Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * fix(#729): path to PLIST to update for Apps Plus URL Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore(#729): enable tag and uploads Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#729] Clean CI/CD script (#737) * chore(#729): more debug Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore(#729): more debug Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore(#729): more debug Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: more logs Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore(#729): clean up Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#716] Update ListItem to add AppIcon for leading element (#735) * Add appicon for leading element in liste item and use it oin recirculation module * Remove binary files * update changelog * Update change log * review * Update dependency SwiftFormat/CLI to v0.53.2 (#710) * Update dependency SwiftFormat/CLI to v0.53.2 * doc: update version of SwiftFormat Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [Tooling] Conditional builds and uploads, better logs and notifications (#739) * fix: strip CURL of GitHub API request result Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: fine-tuned Mattermost notifications Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Conditonal builds and uploads Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#738] Update app icons (#740) * [#741] Group labels in ListItem (#742) Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#677] Group labels and associated elements in ChipsPickers (#743) Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#741] Fix accessibility issues on the demo screen of Bars-navigation component (#744) Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [Tooling] Display build tag of demo app in about screen (#745) * feat: display build tag if defined in demo app Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: about screen of demo app to display build tag Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: review - typo Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [Tooling] Use shorter build tag for demo app (#746) Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [Tooling] Improve app build details in demo app about screen (#747) * refactor: improve display of build tag in demo app Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * doc: update CHANGELOG Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [Tooling] Use dev bundle identifier for alpha mode (#748) Otherwise current bundle identifier ending by .qualif for beta mode will be overriden by alpha builds and it won't be possible to keep both TestFlight versions and just-built versions on the same device Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [Doc] Fix broken hyperlinks for some issues in CHANGELOG (#749) Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#654] Update padding in components screen when cards are in one column (#752) * Refactor the way cards are displayed * review Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#702] Disable vocalization of image in cards component (#754) Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonn@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonn@orange.com> * Update CODEOWNERS (#755) Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#719] Set focus on first item in Modules page (#753) Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#692] Update assets in empty state and recirculation modules (#715) * Update asset and rename some * Rename about asset * Update assets with transparancy * Update changelog * Add missing file * review: add yoga_man asset in app * review update changelog Tested-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Display accessibility conformity level in menu, various cleanings (#773, #772) * refactor: changelog - apply keep a changleog rules Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: (SwiftLint) fix some warnings Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: Fastfile - move Mattermost notification about already created tag Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * feat(#772): display accessibility conformity status in menu instead of title Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: review - clean doc Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Update Boosted version from 5.2.3 to 5.3.3 for project documentation (#774) Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Update dependencies, add new accessibility statement, improve CI/CD lanes (#775) * refactor: Fastfile - less lanes and typos, better logs and lanes Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: SwiftFormat - move from v0.53.2 to v0.53.3 Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: update THIRD-PARTY with new versions of dependencies Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: update accessibility statement lib Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: update accessibility statement lib From v1.1.0 to v1.2.0 Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: add new accessibility statement Version for audit of 2024/03/01 Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: review - typo in lane Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#776] New assets for Innovation Cup theme, improved management of themes resources (#777) * chore(#776): update CHANGELOG Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor(#776): suffix of assets for innovation cup Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * feat(#776): add new assets for innovation cup theme Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * chore: remove typo Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor(#776): move assets, update NOTICE.txt Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor(#776): management of assets by theme or not in app and modules Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor: configuration for production Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * refactor(#776): review - fix SwiftLint warnings Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * [#778] Add list of third-party librairies integrated in the app (#779) Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Prepare release 1.0.0 (#780) * doc: improve pre-release instructions Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> * Prepare release 1.0.0 Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> --------- Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Co-authored-by: Florent Maitre <florent.maitre@orange.com> Co-authored-by: Ludovic PINEL <ludovic.pinel@orange.com> Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com> Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Your test device
iPhone 14 Plus
OS Version
17.1.1
App version
v0.18.0
Describe the issue
Inside almost all variants, when there's a "customization" bottom sheet, in most of cases, the focus order is not correct
Sometimes the first element focused is "customization" (instead of page title or main description), sometimes elements inside the sheet are ordered inconsistently.
NB: behavior is correct on variant Buttons>Icons and Sliders demo
Expected Behavior
On each variant page, focus order should be :
3 all interactive elements in demo view (focus forced on first element of this view on page loading)
The text was updated successfully, but these errors were encountered: