Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ReCaptchaLoginFilter with drivers #15702

Closed
MikeAlhayek opened this issue Apr 9, 2024 · 0 comments · Fixed by #15736
Closed

Replace ReCaptchaLoginFilter with drivers #15702

MikeAlhayek opened this issue Apr 9, 2024 · 0 comments · Fixed by #15736
Milestone

Comments

@MikeAlhayek
Copy link
Member

Filters are expensive and should be used very lightly. The ReCaptchaLoginFilter is called on every request when the reCapcha feature is enabled.

We should be able to improve ForgotPassword.cshtml by using shapes to create the form ForgotPasswordForm.

Also, improve Register.cshtml by using shapes to create the RegisterForm shape.

Finally, improve ResetPassword.cshtml by using shapes to create the ResetPasswordForm shape.

This will allow us to inject reCapcha and other shapes into these forms without having the need to use filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants