Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement local storage emulator support for the Amazon S3 Media module, documentation (Lombiq Technologies: OCORE-153) #15677

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Apr 7, 2024

Fixes #15676. Also fixes exception on Media file uploads with S3.

@Piedone Piedone requested a review from agriffard as a code owner April 7, 2024 19:23
@Piedone
Copy link
Member Author

Piedone commented Apr 7, 2024

Could you please also check this out, @neglectedvalue?

@neglectedvalue
Copy link
Contributor

Seems OK for me.

Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
@Piedone
Copy link
Member Author

Piedone commented Apr 8, 2024

Thank you!

@Piedone Piedone requested a review from hishamco April 8, 2024 11:49
@Piedone Piedone merged commit 43c3407 into OrchardCMS:main Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants