-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analyzer errors on latest net9.0 SDK #15712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding --warnaserror -p:RunAnalyzersDuringBuild=True
to the CI builds so we don't get new warnings? I attempted this under #15719, thinking that we don't have any current warnings, but we have 900, actually. I see most of those fixed here (except for the one enforcing XML comments on public members; we can disable that).
src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/StringExtensions.cs
Show resolved
Hide resolved
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
That's a more involved decision. I am just reacting to the default analyzers added to SDK 9 to unblock the benchmarks which are run by multiple teams in MS. |
So doesn't this affect warnings already existing with .NET 8? |
Reverted the changes VS made to editorconfig and it still works with net9.0 so they were not necessary |
Fixes ASP.NET continuous benchmarks running on latest SDK. New default analyzers are breaking the build.