Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzer errors on latest net9.0 SDK #15712

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Fix analyzer errors on latest net9.0 SDK #15712

merged 10 commits into from
Apr 10, 2024

Conversation

sebastienros
Copy link
Member

Fixes ASP.NET continuous benchmarks running on latest SDK. New default analyzers are breaking the build.

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding --warnaserror -p:RunAnalyzersDuringBuild=True to the CI builds so we don't get new warnings? I attempted this under #15719, thinking that we don't have any current warnings, but we have 900, actually. I see most of those fixed here (except for the one enforcing XML comments on public members; we can disable that).

.editorconfig Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@sebastienros
Copy link
Member Author

sebastienros commented Apr 10, 2024

How about adding --warnaserror -p:RunAnalyzersDuringBuild=True to the CI builds so we don't get new warnings?

That's a more involved decision. I am just reacting to the default analyzers added to SDK 9 to unblock the benchmarks which are run by multiple teams in MS.

@Piedone
Copy link
Member

Piedone commented Apr 10, 2024

So doesn't this affect warnings already existing with .NET 8?

@sebastienros
Copy link
Member Author

Reverted the changes VS made to editorconfig and it still works with net9.0 so they were not necessary

@Piedone Piedone merged commit 4c29c61 into main Apr 10, 2024
5 checks passed
@Piedone Piedone deleted the sebros/sdk branch April 10, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants