-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gem cleanup #879
Gem cleanup #879
Conversation
5040127
to
7ce32ac
Compare
One concern I may have is about fits changes. Do you know if this will have an effect on staging? @decimalator ? Other than that, my other concern is about net-http-persistent. I know we dont have an persistent open connections, but im wondering if this had any effect on blazegraph and CVs. Since our triplestore adapter opens connections. |
@straleyb Looks like the triplestore adapter already has net-http-persistent ~> 2.9 as a requirement in its gemspec, so we're pulling it in anyways. I was also able to ingest something with a CV field just fine and queried it out of blazegraph afterwards. I know FITS is used to characterizing files but I don't know what that actually produces in Hyrax so I don't know where to check for changes from 1.0.5. I'm checking what will show up in solr for the fileset of an image on 1.0.5 and 1.5.0 and report back when I can compare. |
Lets kick them out then, listen and coffee rails, and then push it up and merge it in. |
Unfortunately some other gems require coffee-rails and listen, so we'll have to keep them for now. I'm good with if you want to go forward. Then @jechols can weigh in with more in another PR if he thinks he can slice through them. |
Fixes #870