Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem cleanup #879

Merged
merged 5 commits into from
Dec 5, 2019
Merged

Gem cleanup #879

merged 5 commits into from
Dec 5, 2019

Conversation

CGillen
Copy link
Contributor

@CGillen CGillen commented Dec 3, 2019

Fixes #870

@CGillen CGillen force-pushed the feature/gem-cleaning branch from 5040127 to 7ce32ac Compare December 3, 2019 17:06
@straleyb
Copy link
Contributor

straleyb commented Dec 4, 2019

One concern I may have is about fits changes. Do you know if this will have an effect on staging? @decimalator ?

Other than that, my other concern is about net-http-persistent. I know we dont have an persistent open connections, but im wondering if this had any effect on blazegraph and CVs. Since our triplestore adapter opens connections.

@CGillen
Copy link
Contributor Author

CGillen commented Dec 5, 2019

@straleyb Looks like the triplestore adapter already has net-http-persistent ~> 2.9 as a requirement in its gemspec, so we're pulling it in anyways. I was also able to ingest something with a CV field just fine and queried it out of blazegraph afterwards.
I think if we're not going to use it then it probably shouldn't be in our gemfile. I would like to kick listen and coffee-rails out under the same logic, but they're not in the right gemspecs.

I know FITS is used to characterizing files but I don't know what that actually produces in Hyrax so I don't know where to check for changes from 1.0.5. I'm checking what will show up in solr for the fileset of an image on 1.0.5 and 1.5.0 and report back when I can compare.
Edit: Solr data at least doesn't seem to change between uploading with 1.0.5 and 1.5.0.

@straleyb
Copy link
Contributor

straleyb commented Dec 5, 2019

Lets kick them out then, listen and coffee rails, and then push it up and merge it in.

@CGillen CGillen changed the title [WIP] Gem cleanup Gem cleanup Dec 5, 2019
@CGillen CGillen marked this pull request as ready for review December 5, 2019 17:11
@CGillen
Copy link
Contributor Author

CGillen commented Dec 5, 2019

Unfortunately some other gems require coffee-rails and listen, so we'll have to keep them for now.

I'm good with if you want to go forward. Then @jechols can weigh in with more in another PR if he thinks he can slice through them.

@straleyb straleyb merged commit fde5e5f into master Dec 5, 2019
@CGillen CGillen deleted the feature/gem-cleaning branch December 5, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look at the current rails configuration and trim dev gems
2 participants