Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Update pagination configuration #129

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Update pagination configuration #129

merged 2 commits into from
Aug 2, 2018

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Aug 2, 2018

Checklist:

  • Ensure all new and existing tests pass
  • Submit to the develop branch instead of master

Description:

  • Listing, Purchase and Review resources when queried by default return 10 items. With maximum number of parameters per page allowed set to 100.

Query parameter to use:

  • page indicates the pagination page number
  • results_per_page number of results per page. Defaults to 10, can be between 1 - 100.

Fixes following issues:

@sparrowDom sparrowDom requested a review from franckc August 2, 2018 16:04
@sparrowDom sparrowDom changed the title set default results per page to 10 and max results per page to 100 Update pagination configuration Aug 2, 2018
@micahalcorn
Copy link
Member

@franckc we'll hold off on OriginProtocol/origin-js#264 until Tyler's work is merged, as the resource methods might look completely different.

@sparrowDom sparrowDom mentioned this pull request Aug 2, 2018
@sparrowDom
Copy link
Member Author

@micahalcorn can we still merge the bridge server part, or do we wait for this as well?

@micahalcorn
Copy link
Member

No, I'll let Franck merge ☑️

This was referenced Aug 2, 2018
Copy link
Contributor

@franckc franckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple ! Thanks for making this change.

LGTM

@franckc franckc merged commit 05c7139 into develop Aug 2, 2018
@franckc franckc deleted the sparrowDom/pagination branch August 2, 2018 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants