This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
One line to rule them all #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an easy reference for developers familiar with .env files.
tyleryasaka
force-pushed
the
one-line-to-rule-them-all
branch
3 times, most recently
from
b97bd2e
to
6ee8218
Compare
Also removes docker instructions - our docker setup is not functional right now. It's misleading to have it in our readme.
tyleryasaka
force-pushed
the
one-line-to-rule-them-all
branch
from
6ee8218
to
10ab026
Compare
3 tasks
We can use the origin.js package from npm and guide the developer to use the Rinkeby test net by default. I moved the instructions for local blockchain development further down the file.
Do we even have any tests on demo-dapp? I don't see any in the Everything else is looking good so I'm going to go ahead and merge. |
|
@wanderingstan I've never seen any - we should probably get this straightened out. Either update the checklist or at least create a dummy test and make sure the test command is passing. |
|
Let's update the checklist. Don't think we need additional tests at this stage. |
|
@joshfraser agreed - also I did fix the test script: #112 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
developbranch instead ofmasterNote: tests are not passing for me on
develop, so I'm not worrying about them right now.Description:
Accompanying PR for: OriginProtocol/origin-js#95
See that PR for details.