Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo Context3D.ts async init(canvasConfig?: CanvasConfig): Promise<boolean> #283

Closed
User65-87-11 opened this issue Aug 10, 2023 · 1 comment · Fixed by #284 or #294
Closed

Typo Context3D.ts async init(canvasConfig?: CanvasConfig): Promise<boolean> #283

User65-87-11 opened this issue Aug 10, 2023 · 1 comment · Fixed by #284 or #294

Comments

@User65-87-11
Copy link

Context3D.ts line 40
this.canvas.style.width
if(_height != this.canvas.clientHeight)
this.canvas.style.width = _height + 'px'

should this be
this.canvas.style.height = _height + 'px' ?
@lslzl3000
Copy link
Collaborator

thanks for the report, it should be 'height'
we will fix this later

@lslzl3000 lslzl3000 transferred this issue from Orillusion/orillusion-web Aug 10, 2023
@lslzl3000 lslzl3000 mentioned this issue Aug 11, 2023
Merged
@lslzl3000 lslzl3000 linked a pull request Aug 11, 2023 that will close this issue
fix(canvas): fix external canvas style #284
Merged
lslzl3000 added a commit that referenced this issue Aug 11, 2023
@lslzl3000
fix(canvas): fix external canvas style (#284)
bb89a68 
resolve #283
@lslzl3000 lslzl3000 mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lslzl3000 @User65-87-11