Kiricon build flag #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ava-cassiopeia
requested changes
Sep 7, 2017
| let codeString = fs.readFileSync(`./${fileName}.js`, 'utf-8'); | ||
| codeString = `${scopeStart} ${codeString} ${scopeEnd}`; | ||
|
|
||
| const result = uglify.minify(codeString); |
There was a problem hiding this comment.
Don't we want this to be fully uglified? By default this just does minification.
| To uglify and scope a custom element so that it's usuable for the browser, run the following: | ||
|
|
||
| ```CLI | ||
| create-element --buid [element-name] |
There was a problem hiding this comment.
Can we not have the create-element command find the element file? It seems a little counter intuitive to have it build every time. Plus, we might wanna set something more customizable up, like a basic gulp build or something? Maybe we make it create files called like my-cool-element.element.js or something, so they're easier to find?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add directory help support in a future PR