Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] - About the problem with redgifs #586

Open
gabri25ele opened this issue Apr 17, 2024 · 19 comments
Open

[Suggestion] - About the problem with redgifs #586

gabri25ele opened this issue Apr 17, 2024 · 19 comments

Comments

@gabri25ele
Copy link

gabri25ele commented Apr 17, 2024

about the problems with redgif, mime error etc etc
On reddit there is a script that work very well, maybe can be implemented on handyimage

// ==UserScript==
// @name Redgifs full height video
// @match https://www.redgifs.com/watch/*
// @grant none
// @Version 1.0
// @run-at document-start
// ==/UserScript==
'use strict';

function addCSS(text) {
const el = document.createElement('style');
el.innerHTML = text;

document.documentElement.appendChild(el);

}

addCSS(.previewFeed:has(.Player.Player_isActive){position: fixed;margin: 0;inset: 0;max-width: unset;overflow: hidden;> :not(.Player){display: none}> .Player{height: 100vh;max-height: unset;width: 100%;min-width: 100%;margin: 0;position: relative;.Video-ProgressBar{bottom: 0;transform: translateY(-18px)}video{z-index: 9}}}.App:has(.Player.Player_isActive) :is(.topNav, .ApplicationFooter, .Player-MetaInfo, .Player:not(.Player_isActive)){display: none});

@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

About the problem with redgifs

What problem?

@gabri25ele
Copy link
Author

About the problem with redgifs

What problem?

this problem

sshot-1

to see we need to "reload page normally"
like the reddit problem

@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

can you give an example link?

@gabri25ele
Copy link
Author

can you give an example link?

all links in redgif. any.
Don't tell me no one noticed.
I thought it was a known problem.

@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

I open redgifs - click any video and it works fine for me

@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

try disabling other scripts or extensions which may be breaking this,
try opening the broken video in a new window and see where it leads to (since it says it's not a video)
try checking browser console (ctrl+shift+J) for errors and messages

@gabri25ele
Copy link
Author

I notice two problems:

  1. If I go in https://new.reddit.com/r/NSFWFunny and click on any redgifs link,

reddd

I receive the error
#586 (comment)

  1. If I go to https://www.redgifs.com > EXPLORE and click on any gif... I see, ok, but no full-windows and Handyimage is NOT ACTIVE

@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

Check your handyimage settings that you don't have any risky settings enabled such as "directly open images"
image

@gabri25ele
Copy link
Author

none of this
I keep getting errors with links like this
https://www.redgifs.com/watch/staidmodernpipistrelle

If you want try a CLEAN Firefox portable, which I'm using for testing, you can download it here, I simply installed the script and added the two in the bookmark bar
https://file.io/snkS4rjaH76q

@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

You can get a clean firefox profile on your current browser while keeping your original one by launching firefox.exe -p to bring up profile manager, I've just created a fresh profile and tested - it works with just tampermonkey extension and this script and nothing else changed in the browser

изображение
try clicking right mouse and "inspect element" on the broken video elements and see what the address is, it's supposed to be like this

@gabri25ele
Copy link
Author

I made a clean Firefox for you, to see what I see 😁

for me It worked once, then it didn't work again

err

try my Firefox and see what I see

@Owyn Owyn closed this as completed in b345fc5 Apr 17, 2024
@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

the video url is definitely wrong there, try the new script version - it now waits for the video to load before grabbing it

@gabri25ele
Copy link
Author

nothing changed,
I see the image (not in full window) for a few seconds and then error as before.
why you don't want to see my Firefox portable.
I also wasted time creating it. maybe the problem is there.

@Owyn Owyn reopened this Apr 17, 2024
@Owyn Owyn closed this as completed in 4d42d5a Apr 17, 2024
@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

It's not the firefox which is different but the website's content

try clicking "Inspect" on the video element when the script is not running (disable it or press R after it ran) and see what's inside, for me it's a normal address, for you it's a blob:... for some reason

изображение

the new script version should solve this by avoiding such video urls to grab

@gabri25ele
Copy link
Author

ok, now I see, but... but... simple view, not only gif at full-window
as if handy image was disabled
one

due

@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

handy image was disabled

it doesn't activate since there is no proper video to grab and use (else there'd be that error you've seen), only a :blob for some reason for you, maybe redgifs does that for visitors from your country now, you could try Chrome to confirm it's not browser related

@gabri25ele
Copy link
Author

gabri25ele commented Apr 17, 2024

see this,
https://krakenfiles.com/view/ocpwhWlXv6/file.html
it activate random one time after many refresh

I don't know, work better the other script, with that I see how it should be.
sdfsfsdf

@Owyn
Copy link
Owner

Owyn commented Apr 17, 2024

if you mean the style script above - yea, there's no reason it wouldn't work - it removes everything around the video without changing anything unlike here

and this script creates a whole new page (to avoid nasty ads and pop-ups), I can't think of a way to fix this right now

@Owyn Owyn reopened this Apr 17, 2024
Owyn added a commit that referenced this issue Oct 24, 2024
@Owyn
Copy link
Owner

Owyn commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants