Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code improvements #11

Merged
merged 5 commits into from
Nov 5, 2011
Merged

Code improvements #11

merged 5 commits into from
Nov 5, 2011

Conversation

HakanL
Copy link
Contributor

@HakanL HakanL commented Nov 2, 2011

I ran into a few issues that I've fixed:

  • an issue where a collection is modified inside a foreach loop
  • a case when closing a connection can throw an exception (fixed in the java client)
  • some thread-safe issues (_exchanges)
  • max number of open connections was set to 3
  • re-formatted the code to make it easier to read

@HakanL
Fixed issue with modified collection
a88e27d
@HakanL
Added support for a case that was fixed in the java client
b3fa410 
Wrapped some parts that had the potential for not being thread safe
Limited the number of concurrent connections to 2 (was 3)
Implemented cookie support
Cleaned up response handler
@HakanL
Updated formatting
9645a77
@HakanL
Improved waitFor and added waitForEmptySendQueue (to make sure all qu…
a39f4c2 
…eued messages are sent)
@HakanL
Added feature to make sure send queue is empty (good when connecting,…
c785ce4 
… sending, disconnecting so the message is sent to the comet server)
magnusga added a commit that referenced this pull request Nov 5, 2011
@magnusga
Merge pull request #11 from HakanL/master
0fcf58c 
Code improvements
@magnusga magnusga merged commit 0fcf58c into Oyatel:master Nov 5, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HakanL @magnusga